Fix draw order for low-zoom amenity points #4836
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431 Also partially addresses #3880 for low zoom amenity points.
Changes proposed in this pull request:
As mentioned in Symbol and label prioritization is not in sync with the starting zoom levels #3880 manually working through the layers and adjusting the drawing order to match the order of starting zoom levels is maintenance intensive. However, given the relative low number of amenity points rendered at low zoom levels, and how rarely new ones are added or modified (the last time something was modified in these zoom levels was in January 2021 with De-emphasize parking=street_side #4301 as far as I can tell) this is not a big issue. This can also serve as a starting place for defining rendering levels in the SQL queries if that approach is ever taken (the second suggested approach in Symbol and label prioritization is not in sync with the starting zoom levels #3880)
Test rendering with links to the example places:
Bus stops now render above shelters:
Location: https://www.openstreetmap.org/#map=16/43.0436/-87.9453
Before
After
Cave no longer obscured by drinking water
A cave entrance (starting zoom 15) is no longer obscured by a drinking water tap (starting zoom 17) at zoom 17. Location: https://www.openstreetmap.org/#map=17/46.32509/9.42185
Before
After
Large tower no longer obscured by minor dish
A major radio tower (height 374m and starts rendering at zoom 14) is no longer obscured by a small communication dish (starting render zoom 17) at zoom 17. Location: https://www.openstreetmap.org/#map=17/43.11092/-87.92899
Before
After