Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel aligning some icons #3383

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Pixel aligning some icons #3383

merged 1 commit into from
Sep 15, 2018

Conversation

Adamant36
Copy link
Contributor

This PR pixel aligns some icons needed it. Although I do not have any test renderings, because there was no change in code or anything. I did test things on my side though and it went fine. The new icons showed up on the map etc. So I assume everything works. I can provide test renderings if need be though. Also, this PR closes #3362

@Tomasz-W
Copy link

Codes of bbq and bell tower icons are unnatural long, so I've made them again on another templates. Please change their files one more time.

https://gist.github.com/Tomasz-W/4ff000df11e004abf24d5e77f5b8db62
https://gist.github.com/Tomasz-W/18d5cac547924610245808723dd61319

@Tomasz-W Tomasz-W mentioned this pull request Sep 10, 2018
26 tasks
@Adamant36
Copy link
Contributor Author

I updated them. It should be good to go now.

@kocio-pl
Copy link
Collaborator

Nice! Please make a real world rendering of each replaced icon to make sure that it really works. It's always good to make rendering if it's not just a code fix.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Sep 13, 2018

Ok. I figures since it passed Travis it must be good, but I guess you cant really go by that and its better to test it either way. So I'll be sure and create test renders for things like this to from now.

@kocio-pl
Copy link
Collaborator

Sorry for not hinting it earlier - the project is quite active lately and I'm trying to follow the traffic...

@Adamant36
Copy link
Contributor Author

No worries. I figured you have been busy. Its nice to see the project picking up lately.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Sep 14, 2018

@kocio-pl
Copy link
Collaborator

(no examples in California to test)

You can export small part of data directly from OSM.org website, from anywhere in the world.

@Adamant36
Copy link
Contributor Author

@kocio-pl, yeah I guess. It took me days to load the california shapefile and I just didn't want to have to do it all over again. I guess I could create a temporary branch or something though just to test those two icons.

@kocio-pl
Copy link
Collaborator

I see! You can make temporary database and just switch them, here is my dumb script:

#!/bin/bash
sudo service postgresql restart
sudo -u postgres -H -- psql -c "alter database gis rename to temp;"
sudo -u postgres -H -- psql -c "alter database gis2 rename to gis;"
sudo -u postgres -H -- psql -c "alter database temp rename to gis2;"

@Adamant36
Copy link
Contributor Author

Sweet! I'll have to try that. Sounds better then having to set everything up again every time I need to load a new location, like I was doing for the more obscure icons. I just now realized that I can modify code and click reload in Kosmtik without shutting the whole thing down and restarting it every time. That will save me a lot of time in the future.

@Tomasz-W
Copy link

@Adamant36
Copy link
Contributor Author

Thanks. I updated it and it seems to be good now.
fixed ticket icon

@kocio-pl kocio-pl merged commit 0a3c745 into gravitystorm:master Sep 15, 2018
@kocio-pl
Copy link
Collaborator

Thanks, guys!

@Tomasz-W I like how the shrine is less heavy now (that was something I was not sure if it'll work good) and the laying people silhouettes are more clear. It's unexpected for me that even icons designed by the person, who introduced pixel alignment, could be improved in this respect. Good investigating work!

@Adamant36 When making rendering you might crop the output to show only relevant objects, it's easier to see the merits of the change this way.

@Adamant36
Copy link
Contributor Author

Will do.

@Adamant36 Adamant36 deleted the icons branch September 15, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pixel aligning some icons
3 participants