Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for shop=bookmaker #3345

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Add icon for shop=bookmaker #3345

merged 1 commit into from
Aug 22, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Aug 15, 2018

@Tomasz-W
Copy link

@Adamant36 Auto-closing keyword in first post doesn't work (it should be "closes")

@Tomasz-W Tomasz-W mentioned this pull request Aug 15, 2018
26 tasks
@Adamant36
Copy link
Contributor Author

@Tomasz-W Thanks for the heads up.

@lakedistrictOSM
Copy link

Even though I designed it I don't think that this icon works. Maybe just a suit of clubs would be better? You should be able to find a suitably licensed one somewhere that you can use.

@Adamant36
Copy link
Contributor Author

Hhmm ok. Icons arent really my thing. I know nothing about SVG etc. Can you or @Tomasz-W come up with another one if this one doesnt work? I like the current icon, it seems consistant with getting a ticket for a bet or something, but I have no experince with bookmakers. So I'm sure theres a better icon out there.

@Tomasz-W
Copy link

@Adamant36
Copy link
Contributor Author

Adamant36 commented Aug 18, 2018

Node
bookmaker node
Way
bookmaker way

@lakedistrictOSM and @Tomasz-W, what do you think?

@Tomasz-W
Copy link

I'm not fully satysfied by both icons, but I think there are no any different options for bookmaker icon. so we should choose from ticket one, table one or stay with a dot.
@kocio-pl @meased ?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 19, 2018

I'm not convinced at all by @Tomasz-W design in this case, because it has too many details. @lakedistrictOSM design of this icon is OK for me.

@Adamant36
Copy link
Contributor Author

@kocio-pl I'm good with @lakedistrictOSM's icon also compared to that of @Tomasz-W. So can we go with that one?

@kocio-pl
Copy link
Collaborator

Since I have the impression that @lakedistrictOSM is not interested in further working on this and it's sane design for me, I'm going to merge it soon.

@Adamant36
Copy link
Contributor Author

Ok. Thanks. Sounds good to me.

@kocio-pl kocio-pl merged commit 2e43c60 into gravitystorm:master Aug 22, 2018
@kocio-pl
Copy link
Collaborator

Thanks, works as expected also on other places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon for shop=bookmaker
4 participants