Add icon for leisure=outdoor_seating #3328
Conversation
|
@kocio-pl Any chance you could test and merge this? thanks. |
|
I think that z18+ might be better for such places, since this is usually a part of some other object, not a standalone object, so should not be shown too early. |
|
Alright, that makes sense. I updated it. |
project.mml
Outdated
| @@ -1486,7 +1486,7 @@ Layer: | |||
| 'shop' || CASE WHEN shop IN ('no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE '' END, | |||
| 'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END, | |||
| 'leisure_' || CASE WHEN leisure IN ('water_park', 'playground', 'miniature_golf', 'golf_course', 'picnic_table', | |||
| 'fitness_centre', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley') THEN leisure ELSE NULL END, | |||
| 'fitness_centre', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley', 'outdoor_seating') THEN leisure ELSE NULL END, | |||
There was a problem hiding this comment.
Please break this line, so it won't be the longest in this section.
project.mml
Outdated
| @@ -1600,7 +1600,7 @@ Layer: | |||
| 'shop' || CASE WHEN shop IN ('no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE '' END, | |||
| 'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END, | |||
| 'leisure_' || CASE WHEN leisure IN ('water_park', 'playground', 'miniature_golf', 'golf_course', 'picnic_table', 'slipway', | |||
| 'dog_park', 'fitness_centre', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley') THEN leisure ELSE NULL END, | |||
| 'dog_park', 'fitness_centre', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley', 'outdoor_seating') THEN leisure ELSE NULL END, | |||
There was a problem hiding this comment.
Please break this line, so it won't be the longest in this section.
project.mml
Outdated
| @@ -2068,7 +2068,7 @@ Layer: | |||
| 'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END, | |||
| 'leisure_' || CASE WHEN leisure IN ('swimming_pool', 'water_park', 'miniature_golf', 'golf_course', 'fitness_centre', 'sports_centre', 'stadium', 'track', | |||
| 'pitch', 'playground', 'park', 'recreation_ground', 'common', 'garden', 'nature_reserve', 'marina', | |||
| 'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley') THEN leisure ELSE NULL END, | |||
| 'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley', 'outdoor_seating') THEN leisure ELSE NULL END, | |||
There was a problem hiding this comment.
Please break this line, so it won't be the longest in this section.
project.mml
Outdated
| @@ -2235,7 +2235,7 @@ Layer: | |||
| 'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END, | |||
| 'leisure_' || CASE WHEN leisure IN ('swimming_pool', 'water_park', 'miniature_golf', 'golf_course', 'fitness_centre', 'sports_centre', 'stadium', 'track', | |||
| 'pitch','playground', 'park', 'recreation_ground', 'common', 'garden', 'nature_reserve', 'marina', | |||
| 'slipway', 'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley') THEN leisure ELSE NULL END, | |||
| 'slipway', 'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley', 'outdoor_seating') THEN leisure ELSE NULL END, | |||
There was a problem hiding this comment.
Please break this line, so it won't be the longest in this section.
There was a problem hiding this comment.
Done. I was thinking it was getting a little long.
|
@kocio-pl OK. Its done. I was thinking they were getting a little long. |
|
Did you push this new commit? I don't see any change. |
|
I thought I had. It went through the Travis check and everything. So I don't know. It seems to be showing the changes now though. |
|
OK, now it's visible. I have found a place in the city, which tells me it should be further demoted to z19+ to not make a clutter in similar places - outdoor sitting might be small scale object: z18 z19 |
|
I updated it to z19. Hopefully everything is good to go now. |
|
Thanks, now I think it's working good for me. |
Adds icon for leisure=outdoor_seating closes #3241
https://www.openstreetmap.org/#map=19/43.81804/-111.78297 (node)
https://www.openstreetmap.org/#map=19/42.86389/-112.45208 (way)