Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for shop=paint #3323

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add icon for shop=paint #3323

merged 1 commit into from
Aug 3, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Jul 30, 2018

@Tomasz-W Tomasz-W mentioned this pull request Jul 31, 2018
26 tasks
@Tomasz-W
Copy link

Thanks for another PR! :)
PS. Auto-close keyword in first post is broken because of "issue" word between "closes" and issue link.

@Adamant36
Copy link
Contributor Author

Yep :) I wish there were more coders around helping you out. They must be off enjoying their summers or something.

Thanks for the heads up on the closing thing. I keep doing that.

@Tomasz-W
Copy link

Speaking about summer, it would be good to have some features on map before it ends and the weather gets cold. I mean features like #3069 or #3241. So if it's not a problem for you, and you don't have other plans, I think these tags (and other leisure/ sport tags later) should have a prority to add rendering for.

@meased
Copy link
Contributor

meased commented Jul 31, 2018

The handle is not pixel aligned (half a pixel off). Also, the file should be saved as an optimized SVG (there's a file type selector at the bottom of the Inkscape save dialog).

Otherwise looks good!

@Adamant36
Copy link
Contributor Author

Adamant36 commented Jul 31, 2018

@Tomasz-W, sure I can do that. I was actually thinking about that already. It seemed like #3069 wasn't settled yet though. With the positioning thing and what not. So you think its good to go? And would I be updating the car repair icon to match it also?

@meased Thanks for the heads up. I thought it looked a little off. I'm sure @Tomasz-W can fix it.

@Tomasz-W
Copy link

Tomasz-W commented Aug 1, 2018

Updated icon: https://gist.github.com/Tomasz-W/245e2151c51541d6265f540bc490eafe

@meased I'm using "clean SVG" format which is also allowed.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Aug 1, 2018

Updated icon
https://www.openstreetmap.org/#map=18/37.77677/-122.40551 (Way)
paint way
https://www.openstreetmap.org/#map=19/37.76471/-122.41479 (Node)
paint node

@kocio-pl Any chance you can test and merge this?

@kocio-pl kocio-pl merged commit 83a7ab7 into gravitystorm:master Aug 3, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 3, 2018

Thanks, it works good. You might try using git branches in the future instead of just using master.

@Adamant36
Copy link
Contributor Author

I did that before and it led to a bunch of problems. I might try it again though once I get better at using Git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add special icon for shop=paint
4 participants