-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for shop=paint #3323
Add icon for shop=paint #3323
Conversation
Thanks for another PR! :) |
Yep :) I wish there were more coders around helping you out. They must be off enjoying their summers or something. Thanks for the heads up on the closing thing. I keep doing that. |
Speaking about summer, it would be good to have some features on map before it ends and the weather gets cold. I mean features like #3069 or #3241. So if it's not a problem for you, and you don't have other plans, I think these tags (and other leisure/ sport tags later) should have a prority to add rendering for. |
The handle is not pixel aligned (half a pixel off). Also, the file should be saved as an optimized SVG (there's a file type selector at the bottom of the Inkscape save dialog). Otherwise looks good! |
@Tomasz-W, sure I can do that. I was actually thinking about that already. It seemed like #3069 wasn't settled yet though. With the positioning thing and what not. So you think its good to go? And would I be updating the car repair icon to match it also? @meased Thanks for the heads up. I thought it looked a little off. I'm sure @Tomasz-W can fix it. |
Updated icon: https://gist.github.com/Tomasz-W/245e2151c51541d6265f540bc490eafe @meased I'm using "clean SVG" format which is also allowed. |
Updated icon @kocio-pl Any chance you can test and merge this? |
Thanks, it works good. You might try using git branches in the future instead of just using master. |
I did that before and it led to a bunch of problems. I might try it again though once I get better at using Git. |
Adds icon for shop=paint which closes #3288
https://www.openstreetmap.org/#map=19/37.77712/-122.40170 (Way)
https://www.openstreetmap.org/#map=19/37.76481/-122.41495 (Node)