Remove dedicated photo icon for deprecated shop=photography

[maro-21]

shop=photography is used only 72 times. Why do we render it?
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dphotography

[dch0ph]

This is presumably historical, before the tagging was clearly established.

Quickly scanning over other cases where same icon is shown for different tags, shop=fishmonger is in the same category; comparison to shop=seafood. [Curiously, the wiki claims that Carto doesn't render shop=fishmonger, which is not the case.]

Simple enough to remove the rendering. The only question is whether to make this explicit. The catch-all for shops means that "not rendering" shop=photography with an icon means that it will still be rendered with a purple dot. This is different behaviour for other objects, where "not rendering" means that they disappear from the map, which provides stronger feedback that something needs fixing.

We could add photography to the list of shops that we do not show, along with yes, vacant etc.? This "explicit non-render" could last until it was effectively no longer present in the data (e.g. < 10).

[imagico]

Reviewing the list of shops with dedicated rendering is certainly a good idea.

shop=fishmonger had been added in #2159 - when it was in substantial use and addition was specifically to support precise tagging for non-seafood fish shops. This tagging has, unfortunately, been nearly abandoned since then so it makes sense for us to adjust. This is a good example how our well meaning efforts to support semantically differentiated tagging are not always successful, in particular when other actors in the OSM world push for flat and undifferentiated tagging.

But let's keep things separate and not combine different things.

shop=photography is definitely something that should be removed as a dedicated rendering. For the question of rendering it with a dot - we have an issue for discussing that in general already: #5014. Expanding the list of exclusion values is not a sustainable approach IMO, removing the catch-all in favor of an automatically generated positive list is the way to go i think.

The more important thing to address in the wider context, however, is #1697, which practically depends on #3880 - since rendering a catch-all for shops while not rendering crafts at all substantially influences mappers - like with craft=photographer vs. shop=photo_studio.

[maro-21]

[Curiously, the wiki claims that Carto doesn't render shop=fishmonger, which is not the case.]

Fixed.

The only question is whether to make this explicit. The catch-all for shops means that "not rendering" shop=photography with an icon means that it will still be rendered with a purple dot. This is different behaviour for other objects, where "not rendering" means that they disappear from the map, which provides stronger feedback that something needs fixing.

What I meant is of course change the rendering to a shop icon with a dot.