-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bus stops should have priority over shelters #2431
Comments
Another tagging options is the attribute shelter on the bus_stop. But a detailed mapping should be possible, yes. |
@HolgerJeromin here the shelter is mapped as an area and the bus_stop is mapped as a point. Do you have an idea how to combine these two features? |
@manfredbrandl There is a stop_area relation: https://www.openstreetmap.org/relation/5552716 |
Here you have another example: https://www.openstreetmap.org/relation/5519522 |
Key:public_transport in the wiki: https://wiki.openstreetmap.org/wiki/Tag:public_transport%3Dstop_area#Members |
Is anybody ready to add the code which shows bus shelters on z19+? I'm willing to help if somebody likes to try. |
related to #964 |
Just an idea, I don't know if this is possible: Currently blue is used for public transport features, but grey for shelters. Since the shelters mentioned here are also public transport features, I think we should make them blue if they are tagged As an optional, second step, the shelters rendering importance may be reduced. Since bus stop shelters and other shelters are different things now, this probably can be done easily for the bus stop shelters only, without modifying the other shelter types. Thus, its less likely that this change has unwanted results elsewhere. |
I suppose someone thought about it before, but maybe it would be better to just make special version of bus stop icon with shelter? Something like OSMAnd is doing. It could also render in similar way public transport shelters. When I'm on the road cycling and sometimes I need to find shelter from the rain fast, I prefer to have shelter icon rendered but bus stop icon is more important generally :D |
Are you talking about one object tagged as If there are two separate objects, one |
Yes, indeed I was thinking highway=bus_stop shelter =yes. Its a pity that it was not introduced. If combining two separate objects is hard to implement, it would be maybe better to come back to #3124 solution and then prioritize bus stop with shelter icon over amenity=shelter? |
Some notes to the first message in this issue of 2016:
@Robot8A: The bus_stop icon is shown in this example in zoom level 19. Has it been moved further away from the shelter since your posting in 2016? Or did you want to see it also in zoom level 18 (or lower)? Or did anything change in the style since 2016? I have an example from my city where the bus_stop icon is not even shown in zoom level 19: https://www.openstreetmap.org/node/273533270.
I am not very familiar with the restrictions of the rendering in openstreet map carto and its style, and I am not 100% sure what you meant by "the bus icon is displayed before the shelter icon" and I wanted to ask a maybe stupid question (perhaps this is also what you meant with "before"?): Why can the bus_stop icon not be rendered over the shelter area (and its icon), and if it's very near to the shelter, also with an overlapping? This also happens with other icons which are very near, e.g. It would look like this – and wouldn't that be ok? (And easy to implement in the style? – I don't know ... sorry.) And much better than no bus stop icon at all?
And if shelters with Or like this (if the shelter icon keeps its grey colour): But the visually best variant is probably the first ... And also with regard to the importance of the two objects – because the bus_stop icon is in the foreground visually. |
Because Mapnik collision handling is too primitive for that. You can either place a symbol adhering to collision detection (i.e. not place it if it would collide) or place it ignoring collisions. But you can't place it allowing collisions with some other symbols but not with others. I quickly looked into that in context of drinking water sources - see here. I think the only way you could do what you indicate would be to generate aggregate svg symbols outside of mapnik. Independent of these technical issues your idea would only work if you implement some sort of displacement to avoid cases where the bus stop and the shelter symbol would be placed directly on top of each other which would not be readable. |
I agree with this |
Please change this. Shelters are hiding the bus-stops, of which only the name is visible (if any). Her is a cluster of 3 stops plus shelters, none is visible (slightly depending on zoom level). |
Changes to amenity-points that make it - fully or partially - adhere to prioritization by starting zoom level would be seen favorably. Specifically prioritizing bus stops over amenity=shelter (same starting zoom level) would be fine as well (but not really feasible without giving everything else a consistent order of priority as well). Prioritizing bus stops over everything else, however, would not be seen favorably because it would cause more problems than it solves. |
It would be nice to apply the same logic to ferry terminals as well as bus stops. Example: the transit shelter obscures the ⚓ icon |
Regardless of this, I could also imagine that |
[Proposal to postpone rendering of public transport shelters continued on #3483, which is more directly connected.]
|
Thanks for the links. Suggest consolidating discussion on #3483, since this seems the route with the most overall support. |
Hi, I've noticed that when you map the shelter next to a bus stop, on the render the shelter icon always overrides the bus stop icon. I consider that the bus stop icon is significantly more important that the shelter one for the general public.
An example can be found here: http://www.openstreetmap.org/?mlat=41.66628&mlon=-0.88670#map=18/41.66629/-0.88670
You could do that when a shelter is placed next to a bus stop (or when a shelter that has the tag shelter_type=public_transport) the bus icon is displayed before the shelter icon.
Thanks in advance.
The text was updated successfully, but these errors were encountered: