Give more priority to museums

[dieterdreist]

Expected behavior

they outrule bars and banks

Actual behavior

the get hidden because of bars and banks

Links and screenshots illustrating the problem

Here's an example https://www.openstreetmap.org/node/6205724716
I am not completely sure whether there are other sideeffects, but it seems as if the museum is hidden because of the bank and the bar. Please check the priorities.

[HolgerJeromin]

Current screenshot shows exactly what you suggest in all zoom levels:

[dieterdreist]

great to read it, but it doesn't represent the situation on my screen (and the museum was added 9 months ago and is still in version 1):

[jeisenbe]

This is the current line where tourism=museum is selected. It is before all amenity features, so museums should have priority over banks, bars, etc:

openstreetmap-carto/project.mml

Lines 1413 to 1418 in ea73a44

	COALESCE(
	'aeroway_' || CASE WHEN aeroway IN ('gate', 'apron', 'helipad', 'aerodrome') THEN aeroway ELSE NULL END,
	'tourism_' || CASE WHEN tourism IN ('alpine_hut', 'apartment', 'artwork', 'camp_site', 'caravan_site', 'chalet', 'gallery', 'guest_house',
	'hostel', 'hotel', 'motel', 'museum', 'picnic_site', 'theme_park', 'wilderness_hut',
	'zoo') THEN tourism ELSE NULL END,
	'amenity_' || CASE WHEN amenity IN ('arts_centre', 'atm', 'bank', 'bar', 'bbq', 'bicycle_rental',

Following the link, I get the same results as @HolgerJeromin - https://www.openstreetmap.org/node/6205724716

So this is a problem with one of the rendering servers, not with this style.

(There is a problem on z18 where the museum icon is shown, but the bar text shows: the museum name is too long to fit in the space, so it is not rendered, but then the bar name fits, so it is shown. This is a known issue, see #234 and PR #2597 which attempted to solve it https://www.openstreetmap.org/node/6205724716#map=18/44.38999/7.54744)

[jeisenbe]

I suppose we could consider giving museums priority over aeroway=helipad, tourism=motel/apartment/etc - is this also an issue?

[StyXman]

It is before all amenity features, so museums should have priority over banks, bars, etc

The query has this ordering:

openstreetmap-carto/project.mml

Lines 1588 to 1591 in ea73a44

	WHERE feature IS NOT NULL
	ORDER BY score DESC NULLS LAST,
	way_pixels DESC NULLS LAST
	) AS amenity_points

and score is defined as:

openstreetmap-carto/project.mml

Lines 1467 to 1479 in ea73a44

	CASE
	WHEN "natural" IN ('peak', 'volcano', 'saddle') THEN
	CASE
	WHEN tags->'ele' ~ '^-?\d{1,4}(\.\d+)?$' THEN (tags->'ele')::NUMERIC
	ELSE NULL
	END
	WHEN "waterway" IN ('waterfall') THEN
	CASE
	WHEN tags->'height' ~ '^\d{1,3}(\.\d+)?( m)?$' THEN (SUBSTRING(tags->'height', '^(\d{1,3}(\.\d+)?)( m)?$'))::NUMERIC
	ELSE NULL
	END
	ELSE NULL
	END AS score,

This means that it's ordering by (peak, volcano, saddle) elevation or waterfall height, then polygons by size, then the rest. From what I understand about SQL in general, the rest will come in unspecified order, maybe insert order. I also ave the impression that the order in which the style is defined does not impose a rendering order, but I might be mistaken.

[matkoniecz]

This is the current line where tourism=museum is selected. It is before all amenity features, so museums should have priority over banks, bars, etc:

AFAIK order in COALESCE matters when multiple things are tagged at once on one object. So tourism=museum military=bunker will get feature=tourism_museum, not feature=military_bunker.

Compare with say

openstreetmap-carto/project.mml

Lines 1630 to 1635 in ea73a44

	ORDER BY
	CASE
	WHEN power = 'tower' THEN 1
	WHEN power = 'pole' THEN 2
	ELSE NULL
	END

where objects are ordered by type for rendering order

In other words @StyXman is right.

[jeisenbe]

Related to #3880 - Symbol and label prioritization is not in sync with the starting zoom levels - probably would be fixed if that issue is solved.

[StyXman]

order in COALESCE matters when multiple things are tagged at once on one object. So tourism=museum military=bunker will get feature=tourism_museum, not feature=military_bunker

Agreed, but the original question was, as I understand it, when a museum is close to other amenities (POIs?), render it "with higher priority" than those other amenities.

[matkoniecz]

Yes, I just wanted to explain when this specific order matters.

[dieterdreist]

FWIW, no matter how often I clear the browser cache I still see the situation like in the screenshots I have provided. If people see different map tiles depending on the server from which they get them, this would be a different issue not concerning this repo, or would it?

[matkoniecz]

or would it?

Looking at code it seems that there is no well defined order of objects, at least in this case. I think that adding something along ORDER_BY osm_id to ensure that all servers serve the same tiles would be a good idea.

[pnorman]

FWIW, no matter how often I clear the browser cache I still see the situation like in the screenshots I have provided. If people see different map tiles depending on the server from which they get them, this would be a different issue not concerning this repo, or would it?

If the ordering of objects is not deterministic then it's a style bug.