Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historic=memorial and tourism=artwork conflicts #3565

Open
Janjko opened this issue Dec 12, 2018 · 4 comments
Open

historic=memorial and tourism=artwork conflicts #3565

Janjko opened this issue Dec 12, 2018 · 4 comments

Comments

@Janjko
Copy link

Janjko commented Dec 12, 2018

There is a problem with tags tourism=artwork and historic=memorial. They have subtags with the same meaning: artwork has artwork_type=sculpture;statue;bust and memorial has memorial=sculpture;statue;bust. A bust icon memorial bust is rendered if you put historic=memorial+memorial=bust. But if you add tourism=artwork on the same node, it is rendered like a generic artwork tourism artwork. Even if you put:

historic=memorial+memorial=bust+tourism=artwork+artwork_type=bust

it still doesn't render a bust.
In reality, all memorial=bust are also tourism=artwork, so it isn't wrong tagging.

In my opinion we should first decide which tag is stronger in case of different values, memorial=* or artwork_type=*. After that, just render whatever is in those tags, or in the stronger tag if there are both.

@kocio-pl kocio-pl added the POI label Dec 12, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Dec 12, 2018
@kocio-pl
Copy link
Collaborator

It is documented on the wiki, so I think it's also worth rendering:

https://wiki.openstreetmap.org/wiki/Key:artwork_type

It might be good to also review other types of artwork by the way.

@jragusa
Copy link
Contributor

jragusa commented Dec 13, 2018

Bust and stone are concerned. I propose to render for now artwork_type=bust with the current memorial=bust icon. It's a rapid fix. Icon of memorial=stone suggests an inscription so I propose for this one to wait for the rendering of natural=stone as node (#2616).

@geozeisig
Copy link

Using the icon tourism artwork for an entire building was for me confusing. This happens when artwork_type=architecture is applied. An example is the Siemens-Villa. Maybe you should make an exception for artwork_type=architecture.

@jragusa
Copy link
Contributor

jragusa commented Dec 17, 2018

@geozeisig good point. Why not the upper part of a greek column of Ionic order as icon for artwork_type=architecture ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants