Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests for tag order on the same object #3446

Open
HolgerJeromin opened this issue Oct 11, 2018 · 2 comments
Open

Regression tests for tag order on the same object #3446

HolgerJeromin opened this issue Oct 11, 2018 · 2 comments

Comments

@HolgerJeromin
Copy link
Contributor

Came up in #3434 (comment)

it would be desirable to have an mechanism where we can formally define which of two conflicting tags wins the rendering. Otherwise these issues become forgotten after a while, and resurface as a side-effect once some layering etc is modified for other reasons.

This would be a classic case for an automated regression test. So if a refactoring changes the order travis for example breaks. If this is a desired change the author can adjust the test to the new order.

First we need a framework to make this automated check happen.
After that a list of desired tag order (shop vs amenity) could be build up.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 1, 2018

Do you have the idea what could be this framework or for some other details?

@jeisenbe
Copy link
Collaborator

This is related to #3880 - Symbol and label prioritization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants