-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special icon for shop=fabric #3289
Comments
I was just looking for an icon for that last night. Theres some good examples on Noun Project https://thenounproject.com/search/?q=fabric Also for shop=sewing if you want to create an issue for it to https://thenounproject.com/search/?q=sewing |
Icon proposal: I'm worried that it looks more like a carpet (we could use it for For There was also a proposition to use violet version of this icon for |
The sewing machine icon should be saved for |
I kind of like the idea of something like a button with a needle through it and some string for the tailor. They are of touch up people then seamstresses. |
The fabric icon looks like paper clips, the carpet icon doesn't really look like anything to me, the sewing icons are good... However, I don't feel every shop needs a special icon, just the popular or very prominent ones. A violet dot is perfectly fine for shops such as these. I feel the same way about craft rendering, it would be nice if they were rendered, but dots are fine, no need to make a thousand icons. |
I suggest that the proposed
These recent issues are just about finding icons for the most popular ones, generally above 6k uses.
I'm happy for similar shops to share the same icon. I'm not keen on introducing more dots unless they have a unique colour (like shop and office do). |
Vote for needle+button |
Gist links: |
I would like to establish output of discussion here. Which icons do you want for which shops, and which ones we should skip? |
I would vote for needle+button for shop=sewig and I don't have an opinion on the icons for shop=carpet and shop=fabric. |
I vote for needle + thread for both fabric and sewing/haberdashery, since it's the clearest icon and both shops are similar. |
@kocio-pl Is |
Needlecraft shops: Nearly 9k collectively A new issue can be opened to discuss |
needle + thread is fine for shop=sewing. I'd rather not render shop=haberdashery due to the similarity to shop=sewing (even the wiki says so) to discourage tag fragmentation. For fabric, the needle+something icons appear unsuitable to me as it fails to show the main article. |
We should probably check with the tagging list which of sewing or haberdashery should be supported. (And maybe someone could do a mass edit to change them all, since the wiki definitions are almost identical) I still prefer needle + thread, and it's worth remembering we use icons that aren't always what a shop mainly sells, eg a cake for confectionery and chocolate shops. What's important is that the icons are easily understood and give some idea about what a shop sells - in this case something to do with sewing. |
New shop=fabric icon 1 is very convincing from my perspective :-) . The upper part has a weaving which makes clear that it is not stationary (paperclip). Even better than my idea with the extra loop. For the carpet, I don't understand the object on the right, maybe it is supposed to be the core the carpet is rolled on, but not intuitive for me. |
@polarbearing Flat carpet version: |
For me, it looks like processor icon. |
looks definitely like a CPU or a chip in general, to me, too @Tomasz-W, @polarbearing |
I understand, yes. Focussing on the topic of this issue, can we agree on 'New shop=fabric icon 1' with the webbing? And the needle/thread one for sewing, leaving lesser used tagging for later decision? |
I like the pattern-version for |
Your flat-carpet version looks good, too @Tomasz-W ! |
Here is a SVG file with flat carpet if someone would like to test it: https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397 |
My votes are:
|
@Adamant36 I think something went wrong with carpets icons (https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397) , there was a space between rolled and unrolled parts of it, and on the test renderings they seem to be joined together. |
Gist link: https://gist.github.com/Tomasz-W/24baa83bbed6e1b56b6d86c54d56579f |
I somehow liked the pattern+roll no 1 from Aug 27, but I can also agree with today's pattern-only. |
My favourites: The proposed fabric icon looks too much like a paper clip (and might get confused with stationery shops) |
pattern-only works fine for me. 👍 |
@Adamant36 There was an error in carpet icon, but I fixed it. Can you test zig-zag version for shop=carpet once more? https://gist.github.com/Tomasz-W/760905dbf57ecf04faf6a527fd9e3397#file-shop-carpet-zigzag-svg |
@Tomasz-W, yeah. Thanks for reminding me. I just got busy. I'll probably do it this weekend sometime. |
@Adamant36 Basing on whole disscussion above, I would go with:
|
https://wiki.openstreetmap.org/wiki/Tag:shop=fabric
7.5k uses
No idea what the icon would look like. I don't think a roll of fabric would work. Any ideas @Tomasz-W?
The text was updated successfully, but these errors were encountered: