Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for chess tables #3039

Closed
Tomasz-W opened this issue Jan 27, 2018 · 17 comments
Closed

Add icon for chess tables #3039

Tomasz-W opened this issue Jan 27, 2018 · 17 comments

Comments

@Tomasz-W
Copy link

Tomasz-W commented Jan 27, 2018

Currently, there are no difference between simple picnic tables (tagged as leisure=picninc_table) and chess tables (tagged as leisure=picnic_table + sport=chess).
https://wiki.openstreetmap.org/wiki/Tag:sport=chess

It may be confusing for map users.

Icon proposal:

sport chess table

@kocio-pl kocio-pl added this to the New features milestone Jan 27, 2018
@polarbearing
Copy link
Contributor

We currently render no sports icon at all. If we would start doing this, a chess table would be much rarer than other kinds of sport.
I'd consider leisure=picnic_table wrong tagging for a chess table, a table tennis table, etc.

@Tomasz-W
Copy link
Author

Related to #844

@Tomasz-W
Copy link
Author

I'd consider leisure=picnic_table wrong tagging for a chess table, a table tennis table, etc.

Due to OSM Wiki, correct tagging of tennis tables is leisure=pitch + sport=table_tennis
https://wiki.openstreetmap.org/wiki/Tag:sport%3Dtable_tennis

@dieterdreist
Copy link

dieterdreist commented Jan 28, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 1, 2018

I like this icon and it wouldn't be the first sport icon we use - we show green icon for golf, mini golf, water park and fitness station. Who wants to prepare the code?

@matthijsmelissen
Copy link
Collaborator

I think chess tables are too specific for our purposes.

@dieterdreist
Copy link

dieterdreist commented Feb 1, 2018 via email

@Tomasz-W
Copy link
Author

Tomasz-W commented Feb 2, 2018

I've prepared this icon because OSM styles should show rather certain elements functions than just it's shapes. Chess tables are for playing chess, not e.g. eating sandwiches (of course you can do it there, but it's not a main function). Anyway, I still would like to see this two types of tables look different.

@polarbearing
Copy link
Contributor

Yes, but we already recognised that tagging chess tables as leisure=picnic_table is wrong already. They should follow the table_tennis example and tag themselves as leisure=pitch, where you can have an extra tag to distinguish ground chess fields from tables. .

I wonder if leisure=pitch is rendered on a node?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 2, 2018

Hm, I also don't think it has anything to do with picnic, it's just abusing the table tag, so new tagging is needed. I will close this ticket now, but it can be reopened once the new tagging is established (let's talk about it on Tagging list).

@Tomasz-W Please post this icon as a gist, so it can be easily reached when needed.

@kocio-pl kocio-pl closed this as completed Feb 2, 2018
@Tomasz-W
Copy link
Author

Tomasz-W commented Feb 2, 2018

https://gist.github.com/Tomasz-W/597055a625898c88eb30eb3eb398628a

@dieterdreist
Copy link

dieterdreist commented Feb 4, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 4, 2018

Well, you're right, it's complicated case... Is anybody ready to prepare the code?

@kocio-pl kocio-pl reopened this Feb 4, 2018
@polarbearing
Copy link
Contributor

The wiki definition for pitch is "area designed for playing a particular sport" and thus a bit wider than the natural language. You would need to discuss that tagging as it is wide-spread.

Besides the tables (which I have seen in two forms, with a dedicated table-top with the squares laid in, or as regular tables to bring your own board), there are outdoor chess fields on the ground.

@dieterdreist
Copy link

dieterdreist commented Feb 4, 2018 via email

@matthijsmelissen
Copy link
Collaborator

I think chess tables are too specific for our purposes.

I will therefore close this issue.

@Tomasz-W
Copy link
Author

Tomasz-W commented Aug 3, 2018

Just for the note. current tagging scheme is:

  • chess tables: leisure=picnic_table + sport=chess
  • chess fields on ground: leisure=pitch + sport=chess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants