-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render different tags on a node & polygon? #2582
Comments
We currently render building names only on buildings mapped as polygons. We could consider changing that but IMO if a mapper wants to specify a name for a building he/she should also be able to map it as a polygon so this seems rather unnecessary. In your case the name does not seem to be the name of the buildings anyway, it should be something like |
We have some inconsistencies. |
@imagico "this is a business name not a building name" I also note a node with office=* name=* doesn't render at all. To me name of a business is more relevant & informative to an end user than a housenumber, on both node & polygon. I think it should be amended. |
We render the name of specific objects which are already rendered, which is why a node with building=yes and a name doesn't render. I don't see us changing the decision to tie names to stuff we render, or deciding to render buildings as points. |
@pnorman I didn't say the node had building=* so I'm unsure if your post is relevant, although it would be helpful if you'd clarify what you mean by "We render the name of specific objects which are already rendered" To clarify it best I can: addr:housenumber=142 The polygon has the additional tag of: Rendered results: I believe they should be consistent & display the, more relevant, name tag. I refer you to this comment for confirmation of my point: #108 (comment) |
@DaveF63 - we got your point but as i explained the name is rendered on the polygon because it is tagged For this to happen someone needs to develop a suitable styling to render these that integrates well with the rest of the map and someone needs to implement it. |
Could you explain why? The inconsistencies of a row of business properties rendered with both name & number, as has been pointed out, looks strange.
I disagree with this. There should be consistency irrelevant of the way it's mapped. Take a large building, often with the same address, but divided into individual offices (maybe on multiple floors) the majority of mappers will add each business as a node. If they're tagged with addresses, this carto will just display loads of '142's. Not very helpful.
To be clear, I'm not talking about an icon, just the name label, as it is with the polygon example I've given. |
It seems to me you misunderstood most of what i wrote. We render features based on their tags and combination of tags. If a feature has a name tag we do not always render the name as a label, we only do so if this is a certain type of feature where we render name labels for and we then do so in a certain styling so the map user can conclude from the way the label is rendered that this is a certain type of feature. In this case we currently render names on polygons tagged as We are considering rendering features tagged with specific, well defined values of
I see no problem here - correctly mapped that is one building polygon with an |
Hi Still considering the rest of your post, but:
Surely address data has to go on individual the nodes of each business? |
Hi
Yes, that is valid tagging, too. |
sent from a phone
On 17 Mar 2017, at 17:33, Christoph Hormann ***@***.***> wrote:
I see no problem here - correctly mapped that is one building polygon with an addr:housenumber and a lot of nodes with office=* and the respective names within that building, possibly with level=* to indicate the floor
you seem to assume that you can infer the address from the building, but this is not everywhere the case. Adding address information to all pois/offices is not "incorrect"
|
I am sorry for inciting a tagging discussion here with my remark - this is not the place for it. We render Since this issue is about rendering building names on buildings mapped as nodes (which i don't think we should do - see above) and on rendering offices (which i think we should do - but there are already issues for that) i am going to close this. Feel free to ask if you don't understand the reasoning or have further reasons why it should be changed, but be specific in terms of practical use cases and how you think it should be rendered please. |
Hi
Is there a reason entities with the same tags render different tags depending if their a polygon or node? My initial feeling is the should be consistent.
addr:housenumber=142
name=The Foundry (this is a business name not a building name so can't be addr:housename)
The polygon has building=yes
The text was updated successfully, but these errors were encountered: