Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z14 - railway=level_crossing displayed on undisplayed railway=disused #2074

Open
matkoniecz opened this issue Mar 5, 2016 · 15 comments
Open

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Mar 5, 2016

https://www.openstreetmap.org/#map=14/51.4687/21.7988
selection_003

It is rather confusing and not particularly useful.

EDIT: Note that displaying disused railway at z14 would not solve this, as it is too early to show this kind of feature.

@polarbearing
Copy link
Contributor

I would consider that, at least in part, also a tagging error. When the railway is disused, it would also be a disused:railway=level_crossing. I do not have to pay special attention anymore as there is not train to come.

@matkoniecz
Copy link
Contributor Author

Note that railway=level_crossing marks place "where a road crosses a railway on the same level" - it is about structure itself. It implies possibility of passing trains but it is equally valid on line with 20 trains in each hour and in place where last train appeared a century ago.

@trigpoint
Copy link

I would consider that, at least in part, also a tagging error. When the railway is disused, it would also > be a disused:railway=level_crossing. I do not have to pay special attention anymore as there is not
train to come.

If the tracks are still present, then you may still have to slow down to cross comfortably.

@aceman444
Copy link

I also think when there is not a real crossing anymore (disused/abandoned railway) and you do not need to slow down much, the level_crossing should be removed or marked 'disused:*'. So that means if the mapper left level_crossing tagged, then it should also be rendered (not automatically hidden).

@ajank
Copy link

ajank commented Sep 10, 2016

I would rather conclude that railway=disused should be rendered more prominently. According to the wiki, railway=disused implies that the track is still in place. Typically, the track will be rusty and might be covered by vegetation, but even such a disused track is a notable topographical feature. In my opinion, it should be rendered at z13+, i.e. the same level as service=spur railways.

Note that it might be impossible to distinguish between a rarely used and a disused railway track by just looking at it at the level crossing. You still have to slow down and beware of trains (although they are unlikely to come). To determine the track status, you have to check official registers or ask the locals who may tell something vague like "there was a cargo train every few months, but I have not seen one for a while" or even contradictory like "the track is disused, but there was a train recently".

@boothym
Copy link
Contributor

boothym commented Apr 4, 2017

I agree that level crossings on disused railways is a valid tagging combination, and should therefore be rendered at the same zoom level so they are visible together.

Either move railway=disused up to z14, or level crossings down to z14 - I'd suggest the former, for the reasons mentioned by @ajank. It would also help make bridges carrying disused railways more prominent.

@boothym
Copy link
Contributor

boothym commented Dec 31, 2017

To move this issue along - here's an example near me at zoom 14 and 15, where you have level crossings shown on their own without a railway near them:

untitled-4
untitled-1
This can be fixed in two ways, either:

  • Level crossings are moved from z14 to z15
    OR
  • Disused railways are shown from z14 instead of z15

I would prefer the second option, as that would also help render bridges carrying disused railways, and make disused lines like the one through this part of the map more prominent: https://www.openstreetmap.org/#map=15/56.1833/-3.0772

Any chance someone could implement this?

@da1910
Copy link

da1910 commented Feb 1, 2019

I can take this, assuming the second fix is desired - moving disused railways to z14+

@da1910
Copy link

da1910 commented Feb 1, 2019

Here's option two from above
screenshot from 2019-02-01 16-36-28

@boothym
Copy link
Contributor

boothym commented Feb 1, 2019

@da1910 thanks. Would it possible to show a comparison screenshot between the current z14 and the new z14 - in a busier area with more than one disused line?

@da1910
Copy link

da1910 commented Feb 14, 2019

Here's prague with some disused lines, new z14, old z14 and z15 for comparison. It's a bit tricky because at z14 even in-use railway lines are pretty close together and pretty busy.
screenshot from 2019-02-14 12-51-41
screenshot from 2019-02-14 12-57-19
screenshot from 2019-02-14 12-57-27

@boothym
Copy link
Contributor

boothym commented Feb 14, 2019

Thanks, looks fine to me. Any chance of rendering this area nearby? https://www.openstreetmap.org/#map=14/50.0769/14.4892

@da1910
Copy link

da1910 commented Feb 15, 2019

No problem:
screenshot from 2019-02-15 14-07-37

@da1910
Copy link

da1910 commented Feb 19, 2019

If we're happy with this solution I'll stick in a pull request and we can close this issue

@boothym
Copy link
Contributor

boothym commented Feb 19, 2019

I'm happy with the solution, though I don't get to decide so feel free to go ahead with the pull request and see what happens :).

For the PR I think it would be good to have screenshots showing a proper before/after at z14 - if you can find an area of the map with disused railways and level crossing that would be great, or use the examples in the OP or my post later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants