-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z14 - railway=level_crossing displayed on undisplayed railway=disused #2074
Comments
I would consider that, at least in part, also a tagging error. When the railway is disused, it would also be a |
Note that railway=level_crossing marks place "where a road crosses a railway on the same level" - it is about structure itself. It implies possibility of passing trains but it is equally valid on line with 20 trains in each hour and in place where last train appeared a century ago. |
If the tracks are still present, then you may still have to slow down to cross comfortably. |
I also think when there is not a real crossing anymore (disused/abandoned railway) and you do not need to slow down much, the level_crossing should be removed or marked 'disused:*'. So that means if the mapper left level_crossing tagged, then it should also be rendered (not automatically hidden). |
I would rather conclude that Note that it might be impossible to distinguish between a rarely used and a disused railway track by just looking at it at the level crossing. You still have to slow down and beware of trains (although they are unlikely to come). To determine the track status, you have to check official registers or ask the locals who may tell something vague like "there was a cargo train every few months, but I have not seen one for a while" or even contradictory like "the track is disused, but there was a train recently". |
I agree that level crossings on disused railways is a valid tagging combination, and should therefore be rendered at the same zoom level so they are visible together. Either move railway=disused up to z14, or level crossings down to z14 - I'd suggest the former, for the reasons mentioned by @ajank. It would also help make bridges carrying disused railways more prominent. |
To move this issue along - here's an example near me at zoom 14 and 15, where you have level crossings shown on their own without a railway near them:
I would prefer the second option, as that would also help render bridges carrying disused railways, and make disused lines like the one through this part of the map more prominent: https://www.openstreetmap.org/#map=15/56.1833/-3.0772 Any chance someone could implement this? |
I can take this, assuming the second fix is desired - moving disused railways to z14+ |
@da1910 thanks. Would it possible to show a comparison screenshot between the current z14 and the new z14 - in a busier area with more than one disused line? |
Thanks, looks fine to me. Any chance of rendering this area nearby? https://www.openstreetmap.org/#map=14/50.0769/14.4892 |
If we're happy with this solution I'll stick in a pull request and we can close this issue |
I'm happy with the solution, though I don't get to decide so feel free to go ahead with the pull request and see what happens :). For the PR I think it would be good to have screenshots showing a proper before/after at z14 - if you can find an area of the map with disused railways and level crossing that would be great, or use the examples in the OP or my post later on. |
https://www.openstreetmap.org/#map=14/51.4687/21.7988
It is rather confusing and not particularly useful.
EDIT: Note that displaying disused railway at z14 would not solve this, as it is too early to show this kind of feature.
The text was updated successfully, but these errors were encountered: