feat!: support configure #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
DarkGenius
reviewed
Aug 22, 2023
rollup.config.js
Outdated
| @@ -29,6 +29,7 @@ export default [ | |||
| resolve(), | |||
| commonjs(), | |||
| typescript({ | |||
| resolveJsonModule: true, | |||
There was a problem hiding this comment.
Is it not enough that it is in the tsconfig.json?
DarkGenius
reviewed
Aug 22, 2023
| closeIconSize?: number; | ||
| onClose?: () => void; | ||
| } | ||
| export const Title: React.FC<React.PropsWithChildren<TitleProps>> = ({ | ||
| children, | ||
| closeIconSize = 23, | ||
| hasSeparator, | ||
| dict = defaultDict, | ||
| closeTitle = i18n('button_close'), |
There was a problem hiding this comment.
In such a case, will switching the language update the default value?
There was a problem hiding this comment.
I'll check
up: yeap
DarkGenius
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #88