feat: added AsideHeaderContext #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunduckcow
force-pushed
the
feat-aside-header-context
branch
from
b43ae3b to
addb8f9
Compare
|
Preview is ready. |
sunduckcow
force-pushed
the
feat-aside-header-context
branch
from
addb8f9 to
4e242e9
Compare
Lunory
reviewed
Aug 14, 2023
|
FooterItem and ActionBar stories don't work |
sunduckcow
force-pushed
the
feat-aside-header-context
branch
from
c66ce24 to
c75549d
Compare
DarkGenius
reviewed
Aug 15, 2023
| size: number; | ||
| } | ||
|
|
||
| const AsideHeaderContext = React.createContext<AsideHeaderContextType>({ |
There was a problem hiding this comment.
Let's move the context to a separate file
DarkGenius
reviewed
Aug 15, 2023
| size: ASIDE_HEADER_COMPACT_WIDTH, | ||
| }); | ||
|
|
||
| export const AsideHeaderContextProvider = AsideHeaderContext.Provider; |
There was a problem hiding this comment.
Check these exports in src/components/index.ts
sunduckcow
force-pushed
the
feat-aside-header-context
branch
from
988cdf0 to
ebffad7
Compare
DarkGenius
reviewed
Aug 15, 2023
| @@ -17,6 +17,7 @@ import controlMenuButtonIcon from '../../../assets/icons/control-menu-button.svg | |||
| import headerDividerCollapsedIcon from '../../../assets/icons/divider-collapsed.svg'; | |||
|
|
|||
| import './AsideHeader.scss'; | |||
| import {AsideHeaderContextProvider} from './AsideHeaderContext'; | |||
There was a problem hiding this comment.
Let's move the import up
DarkGenius
reviewed
Aug 15, 2023
| @@ -4,16 +4,12 @@ import {LogoProps} from '../types'; | |||
| import {Button, Icon} from '@gravity-ui/uikit'; | |||
|
|
|||
| import './Logo.scss'; | |||
| import {useAsideHeaderContext} from '../AsideHeader/AsideHeaderContext'; | |||
DarkGenius
reviewed
Aug 15, 2023
| @@ -7,6 +7,7 @@ import {ASIDE_HEADER_COMPACT_WIDTH, ASIDE_HEADER_EXPANDED_WIDTH} from '../../con | |||
| import settingsIcon from '../../../../.storybook/assets/settings.svg'; | |||
|
|
|||
| import './FooterItemShowcase.scss'; | |||
| import {AsideHeaderContextProvider} from '../../AsideHeader/AsideHeaderContext'; | |||
DarkGenius
reviewed
Aug 15, 2023
| @@ -14,6 +14,7 @@ import { | |||
| } from '../constants'; | |||
|
|
|||
| import './Item.scss'; | |||
| import {useAsideHeaderContext} from '../../AsideHeader/AsideHeaderContext'; | |||
Lunory
approved these changes
Aug 15, 2023
DarkGenius
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.