Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AsideHeader): hide collapse button #219

Merged
merged 1 commit into from
Apr 3, 2024
Merged

feat(AsideHeader): hide collapse button #219

merged 1 commit into from
Apr 3, 2024

Conversation

artemavrin
Copy link
Contributor

adds ability to hide the collapse button

@DarkGenius
Copy link
Collaborator

Please explain for what purpose this modification is needed

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@artemavrin
Copy link
Contributor Author

Hey!
If some service doesn't need to show compact and full side bar, e.g. we need only compact side bar, but this small button on the bottom makes questions for users. So we need to hide it

@DarkGenius DarkGenius merged commit 290d920 into gravity-ui:main Apr 3, 2024
3 checks passed
@gravity-ui-bot gravity-ui-bot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkGenius DarkGenius DarkGenius approved these changes

@Lunory Lunory Awaiting requested review from Lunory Lunory is a code owner

@sunduckcow sunduckcow Awaiting requested review from sunduckcow sunduckcow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemavrin @DarkGenius @gravity-ui-bot