feat(Settings): Added selection feature to the Settings #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
reviewed
Nov 10, 2023
DarkGenius
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
It is now possible to select a setting, a section or a page in the Settings component.
Here's how it looks.
Setting
Section
Page
Nothing fancy here — it just changes current page.
Storybook
You can try it out in the storybook — I added two links for selecting a setting and a section.
Possible usage
This can be used for settings links in URLs.
For example, one may add a button for copying a link to a setting using the
renderRightAdornmentproperty and after someone opens the page with the right link, we can openSettingswith the needed selection through the use ofReact.useEffect.One more thing
I also added an optional
idproperty toSettingsItemPropsandSettingsSectionProps(and alsoSettingsItemandSettingsPageSection).