Skip to content

fix: cannot rewind body after connection loss error #65873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexivanoff wants to merge 1 commit into
base: branch/v17
Choose a base branch
from
Open

fix: cannot rewind body after connection loss error #65873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/kube/proxy/forwarder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package proxy

import (
"bytes"
"context"
"crypto/tls"
"encoding/json"
Expand Down Expand Up @@ -2138,6 +2139,20 @@ func (f *Forwarder) catchAll(authCtx *authContext, w http.ResponseWriter, req *h
return nil, trace.Wrap(err)
}

// Buffering req.Body so that HTTP/2 transport can retry
if req.Body != nil && req.Body != http.NoBody {
bodyBytes, err := io.ReadAll(req.Body)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid buffering entire request body in catchAll

catchAll is the fallback path for non-special Kubernetes routes, and this new io.ReadAll(req.Body) forces full in-memory buffering before forwarding instead of streaming. For large or streaming request bodies (for example, proxied aggregated API/service endpoints), this can significantly increase latency and memory usage, and allows a single authenticated large upload to consume substantial heap on the proxy. This should be bounded or gated so retries don’t require unbounded buffering for every request body.

Useful? React with 👍 / 👎.

if err != nil {
return nil, trace.Wrap(err)
}
req.Body.Close()
req.Body = io.NopCloser(bytes.NewReader(bodyBytes))
req.ContentLength = int64(len(bodyBytes))
req.GetBody = func() (io.ReadCloser, error) {
return io.NopCloser(bytes.NewReader(bodyBytes)), nil
}
}

isLocalKubeCluster := sess.isLocalKubernetesCluster
isListRequest := authCtx.requestVerb == types.KubeVerbList
// Watch requests can be send to a single resource or to a collection of resources.
Expand Down
Loading