-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't sign Teleport binary for Mac due to malformed Mach-O binary #3158
Comments
cc @benarent |
Related to #2979 |
It can be linked to this issue - golang/go#11887 |
PIE and |
Closed
Waiting for the release of Go 1.16 which should have support for packaging the webassets inside the binary. |
What a coincidence https://blog.golang.org/go1.16 :) |
This was referenced Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Signing the
tsh
andtctl
binaries works fine, but attempts to sign theteleport
binary on MacOS are failing with the errormain executable failed strict validation
Apparently this error is raised when the executable being signed does not conform to Apple's strict Mach-O layout rules (vercel/pkg#128) - I highly suspect that this is because of the way we zip the web assets and tack them onto the end of the binary as part of the build process. We had a similar sort of problem when initially building RPMs - when you run
rpmbuild
, the default config tries to strip symbols from the binary. In our case, it ended up stripping the web assets because they just look like junk stuck on the end of the file.Apple will only notarize a package which has a signed payload, so for now we can't sign a full
teleport
archive (although the client onlytsh
package I'm working on should be fine)One idea would be to use something like https://github.com/shurcooL/vfsgen to build the assets directly into the binary rather than the current method.
The text was updated successfully, but these errors were encountered: