Remote tctl execution. #2991
Merged
Remote tctl execution. #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
commented
Sep 16, 2019
| // | ||
| // If the "host auth callback" is not returned, user will be prompted to | ||
| // trust the proxy server. | ||
| func LoadIdentity(idFn string) (*client.Key, ssh.HostKeyCallback, error) { |
There was a problem hiding this comment.
All this code just moved here from tsh.go so it could be reused.
|
retest this please |
russjones
approved these changes
Sep 16, 2019
|
@fspmarshall added you as a reviewer |
fspmarshall
approved these changes
Sep 17, 2019
|
@fspmarshall Technically, nothing prevents OSS users from exporting identity and using tctl remotely with it too, however what tctl will be able to actually do using this exported identity will be limited by whatever the default OSS "admin" role permits, yeah. |
klizhentas
approved these changes
Sep 18, 2019
|
@klizhentas did you have an ETA to release this feat? |
benarent
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1525 by adding ability to use
tctlremotely with--auth-serverand--identityflags.To use it remotely, a user would first need to export identity locally on the auth server using the usual method:
After that, the exported identity file can be used to invoke
tctlfrom a remote node:remote$ tctl status \ --auth-server=192.168.99.102:3025 \ --identity=identity.pem remote$ tctl auth sign \ --auth-server=192.168.99.102:3025 \ --identity=identity.pem \ --user=alice \ --out=alice.pemThe
--auth-serverflag can be supplied multiple times.Closes #1525.