Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsh doesn't accept higher port numbers via -p #1576

Closed
kontsevoy opened this issue Jan 11, 2018 · 1 comment
Closed

tsh doesn't accept higher port numbers via -p #1576

kontsevoy opened this issue Jan 11, 2018 · 1 comment
Labels

Comments

@kontsevoy
Copy link
Contributor

Problem

tsh CLI parsing uses Int16 to parse port numbers. The highest port number can be 65535 but int16 only goes to 32767. That is why we need int32 to reach higher port numbers than 32767. In certain cases this can be handy when you want to run the node client on a random port.

@kontsevoy
Copy link
Contributor Author

This PR fixes it: #1569

@kontsevoy kontsevoy added this to the 2.4.1 "Chicago" milestone Jan 11, 2018
@kontsevoy kontsevoy added the bug label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant