Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BCH cashaddress format #84

Open
soad003 opened this issue Nov 30, 2022 · 1 comment
Open

Support BCH cashaddress format #84

soad003 opened this issue Nov 30, 2022 · 1 comment
Assignees

Comments

@soad003
Copy link
Member

soad003 commented Nov 30, 2022

Bitcoin cash introduced a CashAddrs in 2018. Its a new encoding (only userfacing) for their addresses to avoid mistakes (by introducing checksums and better distinguishability from BTC addresses) (ref 1, ref 2)

Our backend only knows legacy addresses thus entering a CashAddr yields no results. Since it is only an encoding cash addresses can be converted to the legacy format.

I propose to convert CashAddr entered in the search field and other queries on the REST level to support CashAddrs.

Code for the conversion can taken from this tagpack-tool issue.

@soad003
Copy link
Member Author

soad003 commented Aug 9, 2023

regarding the convertion to the legacy format, recently bch introduced a new address format (P2SH32) which is not yet supported by the cashaddress library. We introduced a quick and dirty fix in the gslib (graphsense/graphsense-lib@17c6b3f) which is probably also relevant for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants