add @experimental #944
add @experimental #944
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
spec/Section 3 -- Type System.md
Outdated
| ### @experimental | ||
|
|
||
| ```graphql | ||
| directive @experimental on FIELD_DEFINITION | ENUM_VALUE |
There was a problem hiding this comment.
It would be really useful to support @experimental on argument definitions and input field definitions too.
There was a problem hiding this comment.
Do you have a use case in mind? I mainly copy/pasted the @deprecated definition cause I liked the symmetry there. Is there any reason to allow arguments and input fields to be @experimental but not @deprecated?
There was a problem hiding this comment.
We (Salsify) support lots of equality filtering on fields in our GraphQL API e.g. retrieve a list of products in a certain category. We're experimenting with also supporting more complex filtering via more advanced operators like and, or, not, <, etc. These additional inputs are very much experimental and we don't yet want to commit to maintaining backwards compatibility but we do want clients trying them out and giving us feedback on the API ergonomics. It would be great to mark the advanced filtering field arguments and input fields as @experimental.
It looks like #805 hasn't actually merged yet but the RFC for adding @deprecated to input fields/field arguments seems to have been approved so hopefully this would be symmetrical soon enough.
There was a problem hiding this comment.
Thanks for the context! Symmetry is always good 🤗 . I just pushed changes to add arguments and input fields.
|
Closing in favor of graphql/graphql-wg#1006 |
Pull request for #943