Skip to content

Commit b14e553

Browse files
committed
address pr comments
1 parent 10cbf4b commit b14e553

File tree

2 files changed

+6
-44
lines changed

2 files changed

+6
-44
lines changed

spec/Appendix C -- Grammar Summary.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,8 @@ Directives[Const]?
320320

321321
FieldExtension :
322322

323-
- extend field MemberCoordinate ImplementsInterfaces? Directives[const]?
324-
[lookahead != `{`]
325-
- extend field description MemberCoordinate [lookahead != `{`]
323+
- extend field MemberCoordinate Directives[const]?
324+
- extend field description MemberCoordinate
326325

327326
ArgumentsDefinition : ( InputValueDefinition+ )
328327

@@ -334,11 +333,7 @@ InterfaceTypeDefinition :
334333
FieldsDefinition
335334
- Description? interface Name ImplementsInterfaces? Directives[Const]?
336335
[lookahead != `{`]
337-
338-
InterfaceFieldExtension :
339-
340-
- extend interface MemberCoordinate Directives[const]?
341-
336+
342337
InterfaceTypeExtension :
343338

344339
- extend interface Name ImplementsInterfaces? Directives[Const]?

spec/Section 3 -- Type System.md

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,9 +1109,8 @@ Object type extensions have the potential to be invalid if incorrectly defined.
11091109

11101110
FieldExtension :
11111111

1112-
- extend field MemberCoordinate ImplementsInterfaces? Directives[const]?
1113-
[lookahead != `{`]
1114-
- extend field description MemberCoordinate [lookahead != `{`]
1112+
- extend field MemberCoordinate Directives[const]?
1113+
- extend field description MemberCoordinate
11151114

11161115
Field extensions are used to represent a field which has been extended from some
11171116
previously defined field. For example this may be a GraphQL service which is
@@ -1127,13 +1126,9 @@ extend field User.name @deprecated(”Some reason”)
11271126

11281127
Field validation have the potential to be invalid if incorrectly defined.
11291128

1130-
1. The field must already be defined and a field for a Type
1129+
1. MemberCoordinate must be resolved to an existing field on a object or interface type.
11311130
2. Any non-repeatable directives provided must not already apply to the previous
11321131
field.
1133-
3. Any interfaces provided must not be already implemented by the previous
1134-
field.
1135-
4. The resulting extended field must be a super-set of all interfaces it
1136-
implements.
11371132

11381133
## Interfaces
11391134

@@ -1388,34 +1383,6 @@ defined.
13881383
6. The resulting extended Interface type must be a super-set of all Interfaces
13891384
it implements.
13901385

1391-
#### Interface Field Extensions
1392-
1393-
InterfaceFieldExtension :
1394-
1395-
- extend interface MemberCoordinate Directives[const]?
1396-
1397-
Interface field extensions are used to represent an interface which has been
1398-
extended from some previous interface. For example this may be a GraphQL service
1399-
which is itself an extension of another GraphQL service.
1400-
1401-
In this example, the name field on the User type is deprecated for an interface.
1402-
1403-
```graphql example
1404-
extend interface User.name @deprecated("Some reason.")
1405-
```
1406-
1407-
** Field Validation **
1408-
1409-
Field validation have the potential to be invalid if incorrectly defined.
1410-
1411-
1. The field must already be defined and a field for a Type
1412-
2. Any non-repeatable directives provided must not already apply to the previous
1413-
field.
1414-
3. Any interfaces provided must not be already implemented by the previous
1415-
field.
1416-
4. The resulting extended field must be a super-set of all interfaces it
1417-
implements.
1418-
14191386
## Unions
14201387

14211388
UnionTypeDefinition : Description? union Name Directives[Const]?

0 commit comments

Comments
 (0)