Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for nullish values when defining enums #836

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Allow for nullish values when defining enums #836

merged 1 commit into from
Apr 29, 2017

Conversation

leebyron
Copy link
Contributor

Fixes #832

@leebyron leebyron merged commit 5b06511 into master Apr 29, 2017
@leebyron leebyron deleted the fix-832 branch April 29, 2017 02:04
@exogen exogen mentioned this pull request May 2, 2017
Closed
@Josh68 Josh68 mentioned this pull request Jan 4, 2018
Closed
@IvanGoncharov IvanGoncharov mentioned this pull request Mar 2, 2018
Merged
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 5, 2018
@IvanGoncharov
[Bug Reproduce] Can't use undefined and as enum value
1daa096 
**Extracted from graphql#1267**

From graphql#836 it looks like both `undefined` and `NaN` could be used as an enum values:
```js
const TestEnum = new GraphQLEnumType({
  name: 'TestEnum',
  values: {
    UNDEFINED: { value: undefined },
    NAN: { value: NaN },
  },
});
```
And run this query:
```graphql
{
  undefined: fieldWithEnumInput(input: UNDEFINED)
  NaN: fieldWithEnumInput(input: NAN)
}
```
It will result in:
```json
{
  "data": {
    "undefined": null,
    "NaN": null
  },
  "errors": [
    {
      "message": "Argument \"input\" has invalid value UNDEFINED.",
      "path": [ "undefined" ]
    }
    {
      "message": "Argument \"input\" has invalid value NAN.",
      "path": [ "NaN" ]
    }
  ]
}
```
@IvanGoncharov IvanGoncharov mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leebyron @facebook-github-bot