Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude __fixtures__ from dist #1494

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

IvanGoncharov
Copy link
Member

Currently __fixtures__ include in NPM package:
https://github.com/graphql/graphql-js/tree/npm/__fixtures__
Cleanup from #1471
Don't like how it's make package.json less readable but it's a normal temporary solution.

@IvanGoncharov IvanGoncharov added this to the v14.0.0 milestone Aug 29, 2018
Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning those up!

@IvanGoncharov IvanGoncharov mentioned this pull request Aug 30, 2018
@IvanGoncharov
Copy link
Member Author

Thanks for cleaning those up!

It's the cycle of life first you break things and then you fix them and hopefully don't introduce new bugs in the process 😄

@IvanGoncharov IvanGoncharov merged commit c2dfccf into graphql:master Aug 30, 2018
@IvanGoncharov IvanGoncharov deleted the removeFixturesFromDist branch September 3, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants