Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'lexographicSortSchema' #1208

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Jan 22, 2018

@leebyron Following your suggestion in #1199 I reimplemented lexographicSortSchema without changing any existing functionality or adding new API.

Can you please review it?

@leebyron leebyron merged commit 6a1eddf into graphql:master Jan 29, 2018
@leebyron
Copy link
Contributor

Excellent work, thanks for adding a great test suite

@IvanGoncharov IvanGoncharov deleted the lexographicSortSchema branch January 29, 2018 21:05
@marktani
Copy link

Isn't it called lexicographic instead of lexographic?

@IvanGoncharov
Copy link
Member Author

@marktani Good catch! You rock in spelling 🎸
Wikipedia:Lexicographical_order + on GitHub it 8 matches vs 281 matches

I will create PR in a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants