Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to v15 #2303

Closed
mike-marcacci opened this issue Dec 21, 2019 · 9 comments
Closed

Roadmap to v15 #2303

mike-marcacci opened this issue Dec 21, 2019 · 9 comments

Comments

@mike-marcacci
Copy link
Contributor

Hi @IvanGoncharov! I just wanted to check in on the roadmap to v15. I missed the last WG meeting, so perhaps this was discussed and I just didn't see it on the notes.

I know that previously we had discussed releasing 15 quickly (last month or so) with the existing breaking changes, and then releasing v16 with the TypeScript rewrite in early 2020, to corresponding with the next cut of the spec.

Is this still the game plan? There are several pieces sitting in master (such as intermediate interfaces) that could provide immediate value. If we're waiting on any other pieces, let me know and I can try to get some time over the next couple weeks to work on them.

@IvanGoncharov
Copy link
Member

Hi @mike-marcacci

So the plan is as follows I'm finishing #2248 today and releasing 15.0.0-alpha.2.
I will ping GraphiQL guys and Apollo guys to test it and report if anything is broken.
After that release 15.0.0-rc.1 and encourage the general public to try it (twitter and your article) wait for 1 week and release 15.0.0.

What do you think?

@mike-marcacci
Copy link
Contributor Author

This sounds great – thanks so much @IvanGoncharov. Do let me know if you need any help!

@IvanGoncharov
Copy link
Member

@mike-marcacci Happy new year 🎄
Sorry for the delay, I release 15.0.0-alpha.2 yesterday and nobody complained.
I will ping GraphiQL team and Apollo guys after the new year.

@mike-marcacci
Copy link
Contributor Author

mike-marcacci commented Dec 31, 2019

Thanks so much for getting that out @IvanGoncharov; I've integrated the new alpha in some of my projects and everything functions correctly. I will note that the typescript types are still flawed (not just "less-than-ideal", but actually incorrect) in the ways they were in DefinitelyTyped, but I'm definitely on-board with preserving this behavior for now as we rework the codebase into TypeScript to prevent making multiple "breaking" type changes.

abernix added a commit to apollographql/apollo-client that referenced this issue Jan 3, 2020
The next major version of `graphql-js` deprecates the `introspectionQuery`
constant (thanks to graphql/graphql-js#2124) that
was previously leveraged in Apollo Client tests for obtaining the
introspection query (to be clear, this is the query used to introspect a
server, not the result of the introspection itself) in one particular test.

This deprecation isn't entirely surprising since the `getIntrospectionQuery`
utility method has existed since `[email protected]` and is the recommended way
to obtain this query in more recent versions of `graphql`, so this changes
that test to use that new method.

I discovered this while investigating our compatibility with the most
recently published `[email protected]` on `apollo-server`,
`apollo-tooling` and `apollo-client`.  Other than this, I didn't encounter
any test failures when updating the root `graphql` dev-dependency to
`[email protected]`!

Deprecated by: graphql/graphql-js#2124
In Response to: graphql/graphql-js#2303
Relates to: apollographql/apollo-server#3649
Relates to: apollographql/apollo-tooling#1743
benjamn pushed a commit to apollographql/apollo-client that referenced this issue Jan 3, 2020
#5748)

The next major version of `graphql-js` deprecates the `introspectionQuery`
constant (thanks to graphql/graphql-js#2124) that
was previously leveraged in Apollo Client tests for obtaining the
introspection query (to be clear, this is the query used to introspect a
server, not the result of the introspection itself) in one particular test.

This deprecation isn't entirely surprising since the `getIntrospectionQuery`
utility method has existed since `[email protected]` and is the recommended way
to obtain this query in more recent versions of `graphql`, so this changes
that test to use that new method.

I discovered this while investigating our compatibility with the most
recently published `[email protected]` on `apollo-server`,
`apollo-tooling` and `apollo-client`.  Other than this, I didn't encounter
any test failures when updating the root `graphql` dev-dependency to
`[email protected]`!

Deprecated by: graphql/graphql-js#2124
In Response to: graphql/graphql-js#2303
Relates to: apollographql/apollo-server#3649
Relates to: apollographql/apollo-tooling#1743
yaacovCR added a commit to yaacovCR/graphql-tools-fork that referenced this issue Jan 9, 2020
Add description of change and ref to graphql/graphql-js#2303
@jack-guy
Copy link

jack-guy commented Feb 6, 2020

Hi there, thanks so much for the hard work on v15 (Mike in particular, for championing interface implements!)

Per the timeline laid out in this issue, v15 should be ready to graduate from RC. Are there any blockers for that? Thanks!

@IvanGoncharov
Copy link
Member

@jack-guy Working on RC.2 ETA: Today

@aggmoulik
Copy link

Hy @IvanGoncharov I have a previous experience in Typescript and I want to work with you all as I love graphql and want to work from a long time.
I have experience of GSoC'19 in Typescript.

@derek-miller
Copy link

derek-miller commented Apr 1, 2020

Any more updates on the planned release date of v15?

@obi1kenobi
Copy link

Perhaps safe to close this issue now, given that v15 was released?

trevor-scheer added a commit to apollographql/apollo-tooling that referenced this issue Jul 7, 2020
This PR makes the minimal number of changes necessary for the apollo-tooling's
repository's tests to pass for the planned [email protected] release.

Notable changes to implementations are as follows:

an adjustment to account for the new onError callback introduced by
graphql/graphql-js#2074, which deprecated the previously used
ValidationContext.prototype.getErrors method.

utilize the GraphQLEnumValueConfig type instead of GraphQLEnumValue
(which lead to the removal of the name field, which isn't actually needed when
building the values for the GraphQLEnumType constructor.

Ref: graphql/graphql-js#2303

Co-authored-by: Trevor Scheer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants