-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix in extensions-test #2168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cito
force-pushed
the
fix-extensions-test
branch
from
September 12, 2019 16:18
3a505cb
to
6c66cbd
Compare
const fieldExtensions = Object.freeze({ SomeFieldExt: 'field' }); | ||
const argExtensions = Object.freeze({ SomeArgExt: 'arg' }); | ||
|
||
const someInterface = new GraphQLObjectType({ | ||
const someInterface = new GraphQLInterfaceType({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big one. So I didn't test GraphQLInterfaceType
at all 🤦♂
@Cito Thanks a lot 👍
IvanGoncharov
added
the
PR: polish 💅
PR doesn't change public API or any observed behaviour
label
Sep 13, 2019
This was referenced Oct 17, 2019
This was referenced Oct 26, 2019
This was referenced Oct 28, 2019
This was referenced Feb 12, 2020
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.