From c258577177c85f0a9bd1a3a41659a60e2163c83c Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Wed, 21 Jun 2023 22:14:32 +0200 Subject: [PATCH 1/4] [monaco-graphql] remove space trigger character MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this is the most annoying and unnecessary trigger character added thusfar 😆 --- packages/monaco-graphql/src/languageFeatures.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts index af42ab3f90a..3c920f3abcc 100644 --- a/packages/monaco-graphql/src/languageFeatures.ts +++ b/packages/monaco-graphql/src/languageFeatures.ts @@ -217,7 +217,7 @@ export class CompletionAdapter implements languages.CompletionItemProvider { } public get triggerCharacters(): string[] { - return [':', '$', '\n', ' ', '(', '@']; + return [':', '$', '\n', '(', '@']; } async provideCompletionItems( From c721448e94c12389e6cf60058f6135c58353f800 Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Thu, 22 Jun 2023 10:01:28 +0200 Subject: [PATCH 2/4] fix: replace newline --- packages/monaco-graphql/src/languageFeatures.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts index 3c920f3abcc..f542996ba89 100644 --- a/packages/monaco-graphql/src/languageFeatures.ts +++ b/packages/monaco-graphql/src/languageFeatures.ts @@ -217,7 +217,10 @@ export class CompletionAdapter implements languages.CompletionItemProvider { } public get triggerCharacters(): string[] { - return [':', '$', '\n', '(', '@']; + // removing /n character for now until we can + // re-introduce the behavior in a programattic, + // context-aware fashion + return [':', '$', ' ', '(', '@']; } async provideCompletionItems( From f4bdc9cf0df0c14ecd0c979c1033133049edda4f Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Thu, 22 Jun 2023 10:48:25 +0200 Subject: [PATCH 3/4] tiny gitignore fix, spelling fix --- .gitignore | 4 +++- packages/monaco-graphql/src/languageFeatures.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 10563c867b8..b0fa7f20035 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ coverage/ packages/graphiql/typedoc/ dist/ esm/ +packages/*/out/ *.vsix *.tsbuildinfo @@ -41,8 +42,9 @@ packages/codemirror-graphql/*.map !packages/codemirror-graphql/*.config.js packages/graphiql/index.html +packages/graphiql/dev.html packages/graphiql/analyzer.html -packages/graphiql/graphiql.*.js +packages/graphiql/graphiql*.js packages/graphiql/*.css packages/graphiql/*.map packages/graphiql/cypress/screenshots/ diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts index f542996ba89..a85903e29c3 100644 --- a/packages/monaco-graphql/src/languageFeatures.ts +++ b/packages/monaco-graphql/src/languageFeatures.ts @@ -218,7 +218,7 @@ export class CompletionAdapter implements languages.CompletionItemProvider { public get triggerCharacters(): string[] { // removing /n character for now until we can - // re-introduce the behavior in a programattic, + // re-introduce the behavior in a programmatic, // context-aware fashion return [':', '$', ' ', '(', '@']; } From a07fdb7e896824cd5c6abdb102d3d1b6095588b1 Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Thu, 22 Jun 2023 10:55:40 +0200 Subject: [PATCH 4/4] clean up gitignores --- packages/vscode-graphql-execution/.gitignore | 1 - packages/vscode-graphql/.gitignore | 8 -------- 2 files changed, 9 deletions(-) delete mode 100644 packages/vscode-graphql-execution/.gitignore delete mode 100644 packages/vscode-graphql/.gitignore diff --git a/packages/vscode-graphql-execution/.gitignore b/packages/vscode-graphql-execution/.gitignore deleted file mode 100644 index 1fcb1529f8e..00000000000 --- a/packages/vscode-graphql-execution/.gitignore +++ /dev/null @@ -1 +0,0 @@ -out diff --git a/packages/vscode-graphql/.gitignore b/packages/vscode-graphql/.gitignore deleted file mode 100644 index 4058a3dfc84..00000000000 --- a/packages/vscode-graphql/.gitignore +++ /dev/null @@ -1,8 +0,0 @@ -out -node_modules -.vscode-test/ -*.vsix -.vscode/ - -.DS_Store -.envrc \ No newline at end of file