Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom keymaps #2583

Open
thomasheyenbrock opened this issue Jul 22, 2022 · 0 comments
Open

Using custom keymaps #2583

thomasheyenbrock opened this issue Jul 22, 2022 · 0 comments
Labels
@graphiql/react graphiql

Comments

@thomasheyenbrock
Copy link
Collaborator

Support for different keymaps has been added in #2501. However we only import the sublime keymap by default. If one would simply pass a different keyMap prop (e.g. vim) CodeMirror will throw an error.

I see two possible solutions (cc @acao):

  • Either we keep the behavior and properly document that users have to import custom keymaps themselves.
  • Or we import the chosen keymap(s) on runtime dynamically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@graphiql/react graphiql
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasheyenbrock