From 0ae5e2d1b986633bf78c56884e817fdf89bd2903 Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Thu, 22 Jun 2023 11:00:37 +0200 Subject: [PATCH] [monaco-graphql] remove newline trigger character (#3253) --- .gitignore | 4 +++- packages/monaco-graphql/src/languageFeatures.ts | 5 ++++- packages/vscode-graphql-execution/.gitignore | 1 - packages/vscode-graphql/.gitignore | 8 -------- 4 files changed, 7 insertions(+), 11 deletions(-) delete mode 100644 packages/vscode-graphql-execution/.gitignore delete mode 100644 packages/vscode-graphql/.gitignore diff --git a/.gitignore b/.gitignore index 10563c867b8..b0fa7f20035 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ coverage/ packages/graphiql/typedoc/ dist/ esm/ +packages/*/out/ *.vsix *.tsbuildinfo @@ -41,8 +42,9 @@ packages/codemirror-graphql/*.map !packages/codemirror-graphql/*.config.js packages/graphiql/index.html +packages/graphiql/dev.html packages/graphiql/analyzer.html -packages/graphiql/graphiql.*.js +packages/graphiql/graphiql*.js packages/graphiql/*.css packages/graphiql/*.map packages/graphiql/cypress/screenshots/ diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts index af42ab3f90a..a85903e29c3 100644 --- a/packages/monaco-graphql/src/languageFeatures.ts +++ b/packages/monaco-graphql/src/languageFeatures.ts @@ -217,7 +217,10 @@ export class CompletionAdapter implements languages.CompletionItemProvider { } public get triggerCharacters(): string[] { - return [':', '$', '\n', ' ', '(', '@']; + // removing /n character for now until we can + // re-introduce the behavior in a programmatic, + // context-aware fashion + return [':', '$', ' ', '(', '@']; } async provideCompletionItems( diff --git a/packages/vscode-graphql-execution/.gitignore b/packages/vscode-graphql-execution/.gitignore deleted file mode 100644 index 1fcb1529f8e..00000000000 --- a/packages/vscode-graphql-execution/.gitignore +++ /dev/null @@ -1 +0,0 @@ -out diff --git a/packages/vscode-graphql/.gitignore b/packages/vscode-graphql/.gitignore deleted file mode 100644 index 4058a3dfc84..00000000000 --- a/packages/vscode-graphql/.gitignore +++ /dev/null @@ -1,8 +0,0 @@ -out -node_modules -.vscode-test/ -*.vsix -.vscode/ - -.DS_Store -.envrc \ No newline at end of file