Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import macros individually [regression] #296

Closed
andy128k opened this issue Dec 18, 2018 · 6 comments
Closed

Unable to import macros individually [regression] #296

andy128k opened this issue Dec 18, 2018 · 6 comments
Labels
bug Something isn't working regression

Comments

@andy128k
Copy link
Contributor

With 0.11.0 release it is again required to write #[macro_use] extern crate juniper;. With version 0.10.0 import of macro worked well.

Bisect shows this commit as a reason.

@LegNeato LegNeato added bug Something isn't working regression labels Dec 18, 2018
@theduke
Copy link
Member

theduke commented Dec 18, 2018

Partial fix: #298 , but I'm still investigating some other errors with 2018 edition crates.

@theduke
Copy link
Member

theduke commented Dec 18, 2018

Also looks like #251 wasn't properly rebased, we should check if anything else got dropped.

@LegNeato
Copy link
Member

FWIW this was the commit in 0.10.0 that added macro importing support: d496220

@theduke
Copy link
Member

theduke commented Dec 18, 2018

Ah also I just discovered: since we bumped minimum to 1.30 anyway, we can stop using local_inner_macros and instead use the $crate:: method as described here: https://rust-lang-nursery.github.io/edition-guide/rust-2018/macros/macro-changes.html

@theduke
Copy link
Member

theduke commented Dec 18, 2018

Ok I believe the macro issues should be fine now (in the PR).

Except a for a problem with the custom_derives in 2018 edition crates:
the module import hack we use in custom derives to make them work both inside and outside of the juniper crate fails.
The use_everything macro somehow does not work properly anymore and none of the types can be found.

@theduke
Copy link
Member

theduke commented Dec 19, 2018

Fixed and published as 0.11.1.

@theduke theduke closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

No branches or pull requests

3 participants