Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deprecation directive for field args, directive args and input fields #1446

Closed
flbraun opened this issue Aug 18, 2022 · 4 comments
Closed

Comments

@flbraun
Copy link

flbraun commented Aug 18, 2022

The GraphQL spec finally allows using the @deprecated directive on field args, directive args and input fields (see graphql/graphql-spec#805)

It would be nice to support this in Graphene using the established deprecated_reason='....' kwarg to the respective constructors.

@erikwrede
Copy link
Member

Sounds like a great addition!

TODOS for this:

  • Is this already supported in graphql-core?
  • Add deprecation reason field to Meta Options Classes and [Input]Field logic
  • Check that required NonNull input fields are not deprecatable (see spec)

If someone is willing to work on a PR I'd be happy to assist and review!

@vhutov
Copy link
Contributor

vhutov commented Nov 9, 2022

@erikwrede Hi Erik. Is this issue still relevant? I'd like to give it a try

@erikwrede
Copy link
Member

@vhutov Yes this is still relevant. Sounds great! Feel free to tag me when you need a review 🙂

@erikwrede
Copy link
Member

erikwrede commented Dec 10, 2022

Will be released in 3.1.2, thanks to @vhutov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants