Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay.Connection.__init__ does not call super #131

Closed
miracle2k opened this issue Mar 12, 2016 · 1 comment
Closed

relay.Connection.__init__ does not call super #131

miracle2k opened this issue Mar 12, 2016 · 1 comment

Comments

@miracle2k
Copy link
Contributor

https://github.com/graphql-python/graphene/blob/master/graphene/relay/types.py#L58

Is there a reason why not?

It seems to be the cause of a __init__() got an unexpected keyword argument '_root'" error I am getting using a ConnectionField and a custom relay.Connection subclass. There are some other things going in my code so it's not easy to post an example, but essentially, ConnectionField inherits Field, and the wrapped resolver in Field.internal_type always wants to pass _root.

@syrusakbary
Copy link
Member

Sorry for taking some time in taking a look. I've been in vacations... but I'm back!

relay.Connection as you mentioned should call super. Fixing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants