Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GraphQLInputObjectField using newInputObjectField builder #726

Closed
tkvw opened this issue Sep 20, 2017 · 2 comments
Closed

Deprecate GraphQLInputObjectField using newInputObjectField builder #726

tkvw opened this issue Sep 20, 2017 · 2 comments

Comments

@tkvw
Copy link

tkvw commented Sep 20, 2017

Is it intentional that I can't deprecate an GraphQLInputObjectField using newInputObjectField builder?

(as requested on Gitter)

@bbakerman
Copy link
Member

bbakerman commented Sep 20, 2017

I suspect (but dont know) that is was deliberate in the original graphql.

The spec mentions objects and objects fields as being something that can have deprecation.

Perhaps they felt that input objects cant as easily be deprecated since its more a "required" input.

If you look at http://facebook.github.io/graphql/#sec-The-__Field-Type and contrast it to http://facebook.github.io/graphql/#sec-The-__InputValue-Type you will notice one allows deprecation and one does not.

So even introspection says that its not a thing

That said I can't see a spec statement forbidding deprecation on input fields so one could make an argument it can be allowed.

More color can be found here : graphql/graphql-spec#197 and here graphql/graphql-spec#235

@andimarek
Copy link
Member

this is an issue of the general spec, not this library: see last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants