-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove wasm from repo
#545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes all traces of the WebAssembly (WASM) module from the repository. This includes deleting the dedicated WASM library directory, updating project manifest files to exclude the WASM component from the build and release pipelines, and cleaning up the dependency lock file by removing WASM-specific packages and updating other Rust dependencies. The overall impact is a reduction in project complexity and a clear signal that WASM is no longer a part of this repository's architecture. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a cleanup effort to remove the WebAssembly (wasm) related code from the repository. The changes are straightforward and correctly executed.
The key changes include:
- Removal of the
lib/wasm-libcrate from the workspace members in the rootCargo.toml. - Deletion of the entire
lib/wasm-libdirectory, including its source code, tests, andCargo.toml. - Removal of the
query-planner-wasmpackage from therelease-plz.tomlconfiguration. - An update to
Cargo.lockto reflect the removal of WASM-specific dependencies.
The pull request successfully achieves its goal of excising the WASM functionality. The removals are clean and complete, with no dangling references left behind. The changes look good to me.
✅
|
|
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-df186781-d18a-4bdf-9094-e5b711c1b6be/builder-df186781-d18a-4bdf-9094-e5b711c1b6be0/mrrc5ywjlyg9a0niqyjtmpi36",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:3523a07791c17be7a2e9c08bda6de28bb89458e6e088ce7aee0e35f3d27cda7d",
"size": 1609
},
"containerimage.digest": "sha256:3523a07791c17be7a2e9c08bda6de28bb89458e6e088ce7aee0e35f3d27cda7d",
"image.name": "ghcr.io/graphql-hive/router:pr-545,ghcr.io/graphql-hive/router:sha-f52397d"
} |
related: #527