Skip to content

Conversation

@dotansimha
Copy link
Member

related: #527

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically removes all traces of the WebAssembly (WASM) module from the repository. This includes deleting the dedicated WASM library directory, updating project manifest files to exclude the WASM component from the build and release pipelines, and cleaning up the dependency lock file by removing WASM-specific packages and updating other Rust dependencies. The overall impact is a reduction in project complexity and a clear signal that WASM is no longer a part of this repository's architecture.

Highlights

  • WASM Module Removal: The entire lib/wasm-lib directory, which contained the WebAssembly (WASM) module for the query planner, has been completely removed from the repository, including its source code, configuration, and tests.
  • Dependency Cleanup and Updates: The Cargo.lock file has been significantly updated, removing several WASM-specific dependencies (e.g., console_error_panic_hook, wasm-bindgen-backend) and updating numerous other Rust dependencies to their latest versions. Some new dependencies like block2, objc2, and objc2-encode were also introduced, likely as part of broader dependency resolution.
  • Build Configuration Streamlining: Project manifest files, specifically Cargo.toml and release-plz.toml, have been updated to no longer reference the removed WASM module, streamlining the build and release processes.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cleanup effort to remove the WebAssembly (wasm) related code from the repository. The changes are straightforward and correctly executed.

The key changes include:

  • Removal of the lib/wasm-lib crate from the workspace members in the root Cargo.toml.
  • Deletion of the entire lib/wasm-lib directory, including its source code, tests, and Cargo.toml.
  • Removal of the query-planner-wasm package from the release-plz.toml configuration.
  • An update to Cargo.lock to reflect the removal of WASM-specific dependencies.

The pull request successfully achieves its goal of excising the WASM functionality. The removals are clean and complete, with no dangling references left behind. The changes look good to me.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 215919      ✗ 0    
     data_received..................: 6.3 GB  210 MB/s
     data_sent......................: 84 MB   2.8 MB/s
     http_req_blocked...............: avg=3.62µs   min=661ns   med=1.77µs  max=8.43ms   p(90)=2.5µs   p(95)=2.84µs  
     http_req_connecting............: avg=1.16µs   min=0s      med=0s      max=3.26ms   p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=20.4ms   min=2.14ms  med=19.41ms max=190.03ms p(90)=27.93ms p(95)=31ms    
       { expected_response:true }...: avg=20.4ms   min=2.14ms  med=19.41ms max=190.03ms p(90)=27.93ms p(95)=31ms    
     http_req_failed................: 0.00%   ✓ 0           ✗ 71993
     http_req_receiving.............: avg=158.24µs min=24.37µs med=39.59µs max=137.93ms p(90)=88.51µs p(95)=385.41µs
     http_req_sending...............: avg=24.4µs   min=5.46µs  med=10.48µs max=37.15ms  p(90)=15.59µs p(95)=27.27µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=20.22ms  min=2.09ms  med=19.28ms max=60.32ms  p(90)=27.7ms  p(95)=30.73ms 
     http_reqs......................: 71993   2393.962872/s
     iteration_duration.............: avg=20.84ms  min=7.06ms  med=19.77ms max=256.27ms p(90)=28.38ms p(95)=31.49ms 
     iterations.....................: 71973   2393.297818/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-545 ghcr.io/graphql-hive/router:sha-f52397d

Docker metadata
{
"buildx.build.ref": "builder-df186781-d18a-4bdf-9094-e5b711c1b6be/builder-df186781-d18a-4bdf-9094-e5b711c1b6be0/mrrc5ywjlyg9a0niqyjtmpi36",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:3523a07791c17be7a2e9c08bda6de28bb89458e6e088ce7aee0e35f3d27cda7d",
  "size": 1609
},
"containerimage.digest": "sha256:3523a07791c17be7a2e9c08bda6de28bb89458e6e088ce7aee0e35f3d27cda7d",
"image.name": "ghcr.io/graphql-hive/router:pr-545,ghcr.io/graphql-hive/router:sha-f52397d"
}

@dotansimha dotansimha merged commit ca3d24a into main Nov 3, 2025
27 of 28 checks passed
@dotansimha dotansimha deleted the clear-wasm branch November 3, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant