no-unreachable-types: fix handling wrapped request directive argument types

Author: keijokapp

packages/plugin/__tests__/no-unreachable-types.spec.ts

@@ -166,6 +166,22 @@ ruleTester.run('no-unreachable-types', rule, {
         type Query
       `,
     }),
+    withSchema({
+      name: 'should ignore types from directive arguments with request locations',
+      code: /* GraphQL */ `
+        scalar Scalar0
+        scalar Scalar1
+        scalar Scalar2
+        scalar Scalar3
+        scalar Scalar4
+        directive @q(arg: Scalar0) on QUERY
+        directive @w(arg: [Scalar1]) on QUERY
+        directive @e(arg: [Scalar2]!) on QUERY
+        directive @r(arg: [Scalar3!]) on QUERY
+        directive @t(arg: [Scalar4!]!) on QUERY
+        type Query
+      `,
+    }),
   ],
   invalid: [
     withSchema({

packages/plugin/src/rules/no-unreachable-types.ts

@@ -3,9 +3,10 @@ import {
   ASTVisitor,
   DirectiveLocation,
   GraphQLSchema,
-  isInterfaceType,
   Kind,
   NameNode,
+  getNamedType,
+  isInterfaceType,
   visit,
 } from 'graphql';
 import lowerCase from 'lodash.lowercase';
@@ -99,10 +100,7 @@ function getReachableTypes(schema: GraphQLSchema): ReachableTypes {
     if (node.locations.some(location => RequestDirectiveLocations.has(location))) {
       reachableTypes.add(node.name);
       for (const arg of node.args) {
-        const argTypeName = 'name' in arg.type && arg.type.name;
-        if (argTypeName) {
-          reachableTypes.add(argTypeName);
-        }
+        reachableTypes.add(getNamedType(arg.type).name);
       }
     }
   }