-
Notifications
You must be signed in to change notification settings - Fork 25
Bump Router QP package #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Router QP package #1727
Conversation
Summary of ChangesHello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on integrating an updated version of the Hive Router Query Planner, which streamlines how anonymous GraphQL queries are handled by removing redundant Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-tools/batch-delegate |
10.0.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/delegate |
11.1.4-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
4.2.4-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/fusion-runtime |
1.5.2-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
2.1.20-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.25-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-aws-sigv4 |
2.0.18-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-opentelemetry |
1.2.2-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
2.1.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/router-runtime |
1.0.2-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
2.3.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitch |
10.1.4-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitching-directives |
4.0.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-testing |
2.0.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/wrap |
11.0.6-alpha-cb5d74178ac278a8dff9f3c28389cd01c854c121 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the @graphql-hive/router-query-planner package and adapts the codebase to its new behavior. The changes, which include removing the query prefix from anonymous queries and avoiding extra __typename selections, are consistently applied across tests and snapshots. The logic modification in packages/stitch/src/stitchingInfo.ts to conditionally add __typename only for nested root types is a solid optimization. I have one minor suggestion to further refine the code in that file. Overall, the pull request is well-executed and aligns with its objectives.
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
Hive Router QP no longer adds extra
queryprefix to the anonymous queries.This package updates snapshots and tests based on that, and also it aligns stitching with the qp by removing extra
__typenameselections