fix: update package.json validation

Author: n1ru4l

src/commands/build.ts

@@ -1,4 +1,5 @@
 import * as rollup from "rollup";
+import * as assert from "assert";
 import * as fse from "fs-extra";
 import generatePackageJson from "rollup-plugin-generate-package-json";
 import { autoExternal } from "../rollup-plugins/auto-external";
@@ -430,26 +431,39 @@ function rewritePackageJson(pkg: Record<string, any>, distPath: string) {
 }
 
 export function validatePackageJson(pkg: any) {
-  function expect(key: string, expected: string) {
+  function expect(key: string, expected: unknown) {
     const received = get(pkg, key);
 
-    if (expected !== received) {
-      throw new Error(
-        `${pkg.name}: "${key}" equals "${received}", should be "${expected}"`
-      );
-    }
+    assert.deepEqual(
+      received,
+      expected,
+      `${pkg.name}: "${key}" equals "${JSON.stringify(received)}"` +
+        `, should be "${JSON.stringify(expected)}".\n` +
+        `!!! You can run 'bob bootstrap' for fixing your package.json. !!!`
+    );
   }
 
   expect("main", `${DIST_DIR}/index.js`);
   expect("module", `${DIST_DIR}/index.mjs`);
   expect("typings", `${DIST_DIR}/index.d.ts`);
   expect("typescript.definition", `${DIST_DIR}/index.d.ts`);
 
-  expect("exports['.'].require", `./${DIST_DIR}/index.js`);
-  expect("exports['.'].import", `./${DIST_DIR}/index.mjs`);
-
-  expect("exports['./*'].require", `./${DIST_DIR}/*.js`);
-  expect("exports['./*'].import", `./${DIST_DIR}/*.mjs`);
+  expect("exports['.'].require", {
+    default: `./${DIST_DIR}/index.js`,
+    types: `./${DIST_DIR}/index.d.ts`,
+  });
+  expect("exports['.'].import", {
+    default: `./${DIST_DIR}/index.mjs`,
+    types: `./${DIST_DIR}/index.d.ts`,
+  });
+  expect("exports['./*'].require", {
+    default: `./${DIST_DIR}/*.js`,
+    types: `./${DIST_DIR}/*.d.ts`,
+  });
+  expect("exports['./*'].import", {
+    default: `./${DIST_DIR}/*.mjs`,
+    types: `./${DIST_DIR}/*.d.ts`,
+  });
 }
 
 async function copyToDist(cwd: string, files: string[], distDir: string) {

test/__fixtures__/simple-monorepo/packages/a/package.json

@@ -8,15 +8,32 @@
   },
   "exports": {
     ".": {
-      "require": "./dist/index.js",
-      "import": "./dist/index.mjs"
+      "require": {
+        "default": "./dist/index.js",
+        "types": "./dist/index.d.ts"
+      },
+      "import": {
+        "default": "./dist/index.mjs",
+        "types": "./dist/index.d.ts"
+      }
     },
     "./*": {
-      "require": "./dist/*.js",
-      "import": "./dist/*.mjs"
-    }
+      "require": {
+        "default": "./dist/*.js",
+        "types": "./dist/*.d.ts"
+      },
+      "import": {
+        "default": "./dist/*.mjs",
+        "types": "./dist/*.d.ts"
+      }
+    },
+    "./package.json": "./package.json"
   },
   "buildOptions": {
     "input": "./src/index.ts"
+  },
+  "publishConfig": {
+    "directory": "dist",
+    "access": "public"
   }
-}
+}

test/__fixtures__/simple-monorepo/packages/b/package.json

@@ -8,15 +8,32 @@
   },
   "exports": {
     ".": {
-      "require": "./dist/index.js",
-      "import": "./dist/index.mjs"
+      "require": {
+        "default": "./dist/index.js",
+        "types": "./dist/index.d.ts"
+      },
+      "import": {
+        "default": "./dist/index.mjs",
+        "types": "./dist/index.d.ts"
+      }
     },
     "./*": {
-      "require": "./dist/*.js",
-      "import": "./dist/*.mjs"
-    }
+      "require": {
+        "default": "./dist/*.js",
+        "types": "./dist/*.d.ts"
+      },
+      "import": {
+        "default": "./dist/*.mjs",
+        "types": "./dist/*.d.ts"
+      }
+    },
+    "./package.json": "./package.json"
   },
   "buildOptions": {
     "input": "./src/index.ts"
+  },
+  "publishConfig": {
+    "directory": "dist",
+    "access": "public"
   }
-}
+}

test/__fixtures__/simple/package.json

@@ -8,12 +8,29 @@
   },
   "exports": {
     ".": {
-      "require": "./dist/index.js",
-      "import": "./dist/index.mjs"
+      "require": {
+        "default": "./dist/index.js",
+        "types": "./dist/index.d.ts"
+      },
+      "import": {
+        "default": "./dist/index.mjs",
+        "types": "./dist/index.d.ts"
+      }
     },
     "./*": {
-      "require": "./dist/*.js",
-      "import": "./dist/*.mjs"
-    }
+      "require": {
+        "default": "./dist/*.js",
+        "types": "./dist/*.d.ts"
+      },
+      "import": {
+        "default": "./dist/*.mjs",
+        "types": "./dist/*.d.ts"
+      }
+    },
+    "./package.json": "./package.json"
+  },
+  "publishConfig": {
+    "directory": "dist",
+    "access": "public"
   }
 }