Skip to content

variables in the URL query string are now correctly unmarshalled #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

variables in the URL query string are now correctly unmarshalled #10

wants to merge 1 commit into from

Conversation

@switchtrue
Copy link

@switchtrue switchtrue commented May 3, 2016

json.Unmarshal should take a pointer as the second argument. This was previously erroring but the error was not captured and inspected.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage decreased (-0.05%) to 94.393% when pulling 367302c on mleonard87:master into 52e6de4 on graphql-go:master.

@hallettj hallettj mentioned this pull request Dec 27, 2016
Closed
@chris-ramon chris-ramon mentioned this pull request Oct 15, 2017
Merged
@chris-ramon
Copy link
Member

chris-ramon commented Oct 15, 2017

Thanks a lot @Mleonard87 👍 — closing this one in favor of: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@switchtrue @coveralls @chris-ramon