cleanup and comments

Author: jekiapp

util.go

@@ -1,14 +1,19 @@
 package graphql
 
 import (
-	"encoding/json"
 	"fmt"
 	"reflect"
 	"strings"
 )
 
 const TAG = "json"
 
+// can't take recursive slice type
+// e.g
+// type Person struct{
+//	Friends []Person
+// }
+// it will throw panic stack-overflow
 func BindFields(obj interface{}) Fields {
 	v := reflect.ValueOf(obj)
 	fields := make(map[string]*Field)
@@ -23,13 +28,11 @@ func BindFields(obj interface{}) Fields {
 		var graphType Output
 		if typeField.Type.Kind() == reflect.Struct {
 
+			structFields := BindFields(v.Field(i).Interface())
 			if tag == "" {
-				structFields := BindFields(v.Field(i).Interface())
 				fields = appendFields(fields, structFields)
 				continue
 			} else {
-				structFields := BindFields(v.Field(i).Interface())
-
 				graphType = NewObject(ObjectConfig{
 					Name:   tag,
 					Fields: structFields,
@@ -88,6 +91,7 @@ func getGraphList(tipe reflect.Type) *List {
 		return NewList(String)
 	}
 
+	// finaly bind object
 	t := reflect.New(tipe.Elem())
 	name := strings.Replace(fmt.Sprint(tipe.Elem()), ".", "_", -1)
 	obj := NewObject(ObjectConfig{
@@ -140,18 +144,6 @@ func BindArg(obj interface{}, tags ...string) FieldConfigArgument {
 	return config
 }
 
-func UnmarshalArgs(args map[string]interface{}, pointer interface{}) error {
-	js, err := json.Marshal(args)
-	if err != nil {
-		return fmt.Errorf("ini error 1 %v", err)
-	}
-	err = json.Unmarshal(js, pointer)
-	if err != nil {
-		return fmt.Errorf("ini error 2 %v", err)
-	}
-	return nil
-}
-
 func inArray(slice interface{}, item interface{}) bool {
 	s := reflect.ValueOf(slice)
 	if s.Kind() != reflect.Slice {

util_test.go

@@ -2,18 +2,13 @@ package graphql_test
 
 import (
 	"encoding/json"
-	"github.com/graphql-go/graphql"
-	"github.com/graphql-go/graphql/testutil"
 	"log"
 	"reflect"
 	"testing"
-)
 
-type Human struct {
-	Alive  bool    `json:"alive"`
-	Age    int     `json:"age"`
-	Weight float64 `json:"weight"`
-}
+	"github.com/graphql-go/graphql"
+	"github.com/graphql-go/graphql/testutil"
+)
 
 type Person struct {
 	Human
@@ -22,6 +17,12 @@ type Person struct {
 	Friends []Friend `json:"friends"`
 }
 
+type Human struct {
+	Alive  bool    `json:"alive"`
+	Age    int     `json:"age"`
+	Weight float64 `json:"weight"`
+}
+
 type Friend struct {
 	Name    string `json:"name"`
 	Address string `json:"address"`
@@ -38,29 +39,29 @@ var personSource = Person{
 		Weight: 70.1,
 		Alive:  true,
 	},
-	Name:    "John Doe",
-	Home:    myaddress,
+	Name: "John Doe",
+	Home: Address{
+		Street: "Jl. G1",
+		City:   "Jakarta",
+	},
 	Friends: friendSource,
 }
 
 var friendSource = []Friend{
-	{"Arief", "palembang"},
-	{"Al", "semarang"},
-}
-
-var myaddress = Address{
-	Street: "Jl. G1",
-	City:   "Jakarta",
+	{Name: "Arief", Address: "palembang"},
+	{Name: "Al", Address: "semarang"},
 }
 
 func TestBindFields(t *testing.T) {
-	personObj := graphql.NewObject(graphql.ObjectConfig{
-		Name:   "Person",
+	// create person type based on Person struct
+	personType := graphql.NewObject(graphql.ObjectConfig{
+		Name: "Person",
+		// pass empty Person struct to bind all of it's fields
 		Fields: graphql.BindFields(Person{}),
 	})
 	fields := graphql.Fields{
 		"person": &graphql.Field{
-			Type: personObj,
+			Type: personType,
 			Resolve: func(p graphql.ResolveParams) (interface{}, error) {
 				return personSource, nil
 			},
@@ -118,6 +119,7 @@ func TestBindArg(t *testing.T) {
 	fields := graphql.Fields{
 		"friend": &graphql.Field{
 			Type: friendObj,
+			//it can be added more than one since it's a slice
 			Args: graphql.BindArg(Friend{}, "name"),
 			Resolve: func(p graphql.ResolveParams) (interface{}, error) {
 				if name, ok := p.Args["name"].(string); ok {