Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for disabling supports_block_receipts via environment variables #5756

Open
1 of 2 tasks
vaivanov opened this issue Jan 7, 2025 · 0 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@vaivanov
Copy link

vaivanov commented Jan 7, 2025

Description

Problem
Some blockchain nodes of specific chains return invalid data when calling the eth_getBlockReceipts method. This behavior can cause issues in the functionality of graph-node, particularly when the supports_block_receipts feature cannot be entirely disabled.

Currently, the environment variable GRAPH_ETHEREUM_BLOCK_RECEIPTS_CHECK_TIMEOUT allows configuring the timeout for block receipt checks. However, this is insufficient for completely disabling the functionality.

Proposed Solution
Introduce a new environment variable, such as GRAPH_SUPPORTS_BLOCK_RECEIPTS, to allow disabling the supports_block_receipts feature entirely by setting its value to false.

If the variable is not set, the current default behavior is preserved.
The variable would explicitly override the configuration to skip the supports_block_receipts checks.

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

No response

Some information to help us out

  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.
@vaivanov vaivanov added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant