Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build performance of modules #84

Open
MC-JY opened this issue May 11, 2022 · 3 comments
Open

Improve build performance of modules #84

MC-JY opened this issue May 11, 2022 · 3 comments

Comments

@MC-JY
Copy link

MC-JY commented May 11, 2022

Hi, I'm now using ongdb. I found that the build time of the project is not very fast when I used  mvn -T 1C install -DskipTests command to build the project during Github Actions. So I try to speed up the build performance of the project. The goal here is to clean up dependencies between maven modules in the project in order to improve the build performance.

Thread usage before cleaning up module dependencies was this:
1

Using mvn dependency:analyze command I managed to have an overview of the unused dependencies of every module. I focused only on the dependencies between modules. The following dependencies can be cleaned up:


org.graphfoundation.ongdb:ongdb-geequel-compatibility-spec-suite(/enterprise/cypher/compatibility-spec-suite) -> org.graphfoundation.ongdb:ongdb-enterprise-geequel(enterprise/cypher/cypher)
org.graphfoundation.ongdb:ongdb-geequel-acceptance-spec-suite(enterprise/cypher/acceptance-spec-suite) -> org.graphfoundation.ongdb:ongdb-enterprise-geequel(enterprise/cypher/cypher)

After clean up, the build time has been reduced by 1min40s when I use parallel build during Github Actions.
Thread usage after cleaning up module dependencies was this:
2

Could you help me review this issue? I can submit a PR to improve build performance of the project.

Thank you very much for your attention.
Best regards.

@bradnussbaum
Copy link
Contributor

Hi @MC-JY - thank you for the analysis! I think the dependency cleanup you're proposing is a good optimization. The best way to get it tested out is to make the changes you indicated and submit a PR. If there are no issues with build or tests, etc. then should be good to go.

@bradnussbaum
Copy link
Contributor

@MC-JY Did you intend to submit a PR to cleanup unused dependencies? I'd be interested to try that out and see the improvements to the build times. Thanks.

@crazyyanchao
Copy link

crazyyanchao commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants