Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets rewrite follow-ups and leftoevers #657

Open
boryspoplawski opened this issue Jun 17, 2022 · 0 comments
Open

Sockets rewrite follow-ups and leftoevers #657

boryspoplawski opened this issue Jun 17, 2022 · 0 comments
Labels
enhancement New feature or request P: 3

Comments

@boryspoplawski
Copy link
Contributor

After #579 there are still some less important TODOs and cleanup ideas:

  • Clean unused stuff from struct handle_ops in Pal/include/pal_internal.h (e.g. readbyaddr).
  • Clean up socket/listen/bind/connect ocalls. Currently there are two versions of them (one doing a single syscall, other batching a few) - we need to at least change the names to something more verbose (or remove/rewrite some, needs some thinking and discussion).
  • Clean up lists of allowed error codes in ocalls. Currently most of them allow e.g. for EBADF, which should never be the case if we pass correct arguments.
  • Add void* private into struct shim_sock_handle - this field would be private for each backend (e.g. IP could store some socket options there). We would probably move reuseaddr to there too.
@dimakuv dimakuv added enhancement New feature or request P: 3 labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P: 3
Projects
None yet
Development

No branches or pull requests

2 participants