Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename external APIs #25

Closed
pwmarcz opened this issue Aug 31, 2021 · 1 comment · Fixed by #221
Closed

Rename external APIs #25

pwmarcz opened this issue Aug 31, 2021 · 1 comment · Fixed by #221

Comments

@pwmarcz
Copy link
Contributor

pwmarcz commented Aug 31, 2021

(As discussed in gramineproject/graphene#2662)

Graphene's patched code currently uses an API that contains some internal names ("shim_*", "syscalldb"). I propose the following changes:

  • SYSCALLDB macro -> GRAPHENE_SYSCALL
  • shim_register_library and possibly other functions -> graphene_register_library
  • SHIM_*_OFFSET -> GRAPHENE_*_OFFSET
  • shim_entry_api.h -> graphene_entry_api.h
    • Other shim_*.h files are internal, but this one is a public header file included in patched code

etc.
@pwmarcz
Copy link
Contributor Author

pwmarcz commented Aug 31, 2021 •
edited by mkow
Loading

Probably should be done after project move (gramineproject/graphene#2558) since the name will likely change.

@mkow mkow transferred this issue from gramineproject/graphene Sep 10, 2021
@pwmarcz pwmarcz mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LibOS] Use the syscall interface for custom calls gramineproject/gramine
1 participant
@pwmarcz