Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger monitor tab: use prometheus metrics with type suffixes #720

Open
pavolloffay opened this issue Dec 21, 2023 · 0 comments
Open

Jaeger monitor tab: use prometheus metrics with type suffixes #720

pavolloffay opened this issue Dec 21, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pavolloffay
Copy link
Collaborator

Prometheus exporter in OTEL collector > 0.85 introduced a breaking change to add metric type as suffix to the metric name https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.85.0. The workaround is to disable it in the config https://github.com/grafana/tempo-operator/pull/719/files#diff-87936fd0cd69afd4684045173ec4f602a6700e7cea5354fbdfc31f599169c73eR34.

I propose to keep it enabled but add normalization flags to jaeger query https://github.com/jaegertracing/jaeger/pull/4957/files#diff-a08a9342e4ac19beb41f5827d969372838c67c86105d9d0cd034dd3fa1e40d2cR16

@pavolloffay pavolloffay added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant