Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create grafana-operator datasource CR for tempo if grafanaOperator feature gate is set #423

Closed
2 tasks done
andreasgerstmayr opened this issue May 26, 2023 · 10 comments · Fixed by #619
Closed
2 tasks done
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andreasgerstmayr
Copy link
Collaborator

andreasgerstmayr commented May 26, 2023

Create a grafana-operator datasource CR for tempo if grafanaOperator feature gate is set

https://github.com/grafana-operator/grafana-operator/blob/master/docs/docs/datasources.md

Tasks

@pavolloffay pavolloffay added the help wanted Extra attention is needed label Jul 3, 2023
@andreasgerstmayr andreasgerstmayr added the enhancement New feature or request label Jul 6, 2023
@andreasgerstmayr andreasgerstmayr added the good first issue Good for newcomers label Aug 23, 2023
@ritaCanavarro
Copy link
Contributor

Hi, I would like to take this. Can you please assign it to me?

@frzifus
Copy link
Collaborator

frzifus commented Sep 19, 2023

@andreasgerstmayr should the datasource point to the gateway if enabled?

@andreasgerstmayr
Copy link
Collaborator Author

@andreasgerstmayr should the datasource point to the gateway if enabled?

Yes. However, iirc currently the gateway is missing some endpoints (like /ping) which Grafana requires.

@ritaCanavarro
Copy link
Contributor

Hi @andreasgerstmayr,
We can close this Issue and open two new ones as discussed 😄

@andreasgerstmayr
Copy link
Collaborator Author

Yep, I've created #707 for the GrafanaDatasource with gateway

@andreasgerstmayr andreasgerstmayr linked a pull request Dec 11, 2023 that will close this issue
@andreasgerstmayr
Copy link
Collaborator Author

Completed in #619

@fliegera
Copy link

fliegera commented May 9, 2024

Is this really working?
I installed the Operator Version 4 and created an instance with the following configMap

apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
health:
  healthProbeBindAddress: :8081
metrics:
  bindAddress: 127.0.0.1:8080
webhook:
  port: 9443
leaderElection:
  leaderElect: true
  resourceName: 2c0156f0.integreatly.org
featureGates:
  openshift:
    openshiftRoute: true
    servingCertsService: true
    oAuthProxy:
      defaultEnabled: true
  grafanaOperator: true

When I want to create a Tempostack as follows I get the error that the featuregate grafanaOperator should be enabled

apiVersion: tempo.grafana.com/v1alpha1
kind: TempoStack
metadata:
  name: dev-distributed-tracing
  namespace: dev-distributed-tracing
spec:
  observability:
    tracing:
      jaeger_agent_endpoint: 'localhost:6831'
    grafana:
      createDatasource: true      
  resources:
    total:
      limits:
        cpu: 2000m
        memory: 2Gi
  tenants:
    mode: static
  managementState: Managed
  template:
    queryFrontend:
      jaegerQuery:
        ingress:
          type: route
        enabled: true
  storage:
    secret:
      name: distributed-tracing-s3-secret
      type: s3
  storageSize: 1Gi

@andreasgerstmayr
Copy link
Collaborator Author

Is this really working? I installed the Operator Version 4 and created an instance with the following configMap

apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
[...]
featureGates:
  openshift:
    openshiftRoute: true
    servingCertsService: true
    oAuthProxy:
      defaultEnabled: true
  grafanaOperator: true

Did you edit the ConfigMap of the grafana operator? The grafanaOperator: true must be set in the tempo-operator ConfigMap, which looks like this (note the apiVersion: config.tempo.grafana.com/v1alpha1):

apiVersion: v1
data:
  controller_manager_config.yaml: |
    apiVersion: config.tempo.grafana.com/v1alpha1
    kind: ProjectConfig
    leaderElection:
      leaderElect: true
      resourceName: 8b886b0f.grafana.com
    [...]

@fliegera
Copy link

I now modified the correct ConfigMap. The TempoStack now is created. However there is no datasource created in Grafana.
I am on Openshift 4.13 with the RedHat TempoOperator and Grafana Operator 5.x

@andreasgerstmayr
Copy link
Collaborator Author

@fliegera can you check if a GrafanaDatasource object got created in the cluster? And can we move this discussion in a new issue, this closed RFE isn't the right place for it.

@ritaCanavarro ritaCanavarro removed their assignment May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants