Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The agent should decompress compressed reponses #124

Closed
mem opened this issue Feb 22, 2021 · 1 comment
Closed

The agent should decompress compressed reponses #124

mem opened this issue Feb 22, 2021 · 1 comment
Assignees
@mem
Labels
enhancement New feature or request

Comments

@mem
Copy link
Contributor

mem commented Feb 22, 2021

Currently BBE does not decompress compressed responses (e.g. Content-Encoding: gzip). In order to be able to apply verifications, it's necessary to do so (e.g. fail if body matches / fail if body does not matches).

This also fixes the issue where the probe_http_uncompressed_body_length is always the same as probe_http_content_length.

This is related to prometheus/blackbox_exporter#684.
@mem mem added the enhancement New feature or request label Feb 22, 2021
@mem mem self-assigned this Feb 22, 2021
@rdubrock rdubrock mentioned this issue May 5, 2021
Merged
@mem
Copy link
Contributor Author

mem commented May 19, 2021

This has been added in #144

@mem mem closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mem mem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mem